Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call compile with correct executable #3493

Merged
merged 6 commits into from
Oct 12, 2024
Merged

Call compile with correct executable #3493

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
433286a
import fix
richagadgil Oct 1, 2024
bdfaa6f
remove comment
richagadgil Oct 1, 2024
4aa723f
fix format
richagadgil Oct 2, 2024
62106f4
Update compile_hip.cpp
richagadgil Oct 10, 2024
17adbfe
Merge branch 'develop' into import_fix
causten Oct 11, 2024
4f35b16
fix format
richagadgil Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/targets/gpu/compile_hip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,15 @@ std::vector<std::vector<char>> compile_hip_src_with_hiprtc(std::vector<hiprtc_sr
bool hip_has_flags(const std::vector<std::string>& flags)
{
hiprtc_program prog{" "};
Copy link
Collaborator

@pfultz2 pfultz2 Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is variable is not used, and should be removed. Also the other hip_has_flags function should be removed.


std::string src = " ";
src_file input{"main.cpp", src};
std::vector<src_file> srcs = {input};

try
{
prog.compile(flags, true);
std::string arch = "gfx900";
compile_hip_src(srcs, flags, arch);
return true;
}
catch(...)
Expand Down
Loading