-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile using ASAN on the github CI #3142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff! thanks a lot!
Not working yet, having trouble with linker during link tests |
Alright, looks like things are working now |
1857bd6
to
1a9322d
Compare
It looks like the execute tests are failing because runtime libraries compiled with ASAN require that the programs using them are compiled with ASAN. |
.github/configure-san
Outdated
|
||
CONFIGURE=$(dirname $(dirname $0))/configure | ||
|
||
$CONFIGURE CFLAGS="$COMMON -B$GCC_LIBS" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using --with-build-config="bootstrap-asan"
(or whatever it is) instead, but not sure how to handle tests (some DejaGnu hackery may be needed there).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bootstrap-asan
doesn't work with --disable-bootstrap
, as far as I can tell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right, but I see you've figured it out ;)
I was trying to avoid creating a custom build config file, but in hindsight that's probably the best way to go |
Should be ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Ah, I think the test failures might be due to the execute testsuite running but not linking with ASAN? this is something that happens to me when I do local ASAN builds. If that is the case, then a solution would be to either run only the compile.exp testsuite with |
I managed to get the execute tests working, and it seems like the remaining test failures are down to bugs in GCCRS |
ChangeLog: * .github/workflows/ccpp.yml: Add job for running tests with ASAN. * .github/no-bootstrap-asan.mk: New file. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
The ASAN check should pass now |
This adds a job for running GCC with ASAN to the github CI