CIの導入 #19
Merged
CIの導入 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ESLintの設定を修正し、リンターを走らせました |
Meiryo7743
requested changes
Jan 4, 2025
.github/workflows/lint.yaml
Outdated
Comment on lines
8
to
9
| - name: Checkout main branch | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
8 行目について，PR の base branch に対しても実行されることを考えると「Checkout main branch」の「main」を「target」のような表現に変えてみるのはどうでしょうか？ それなら意図が一層明瞭になって良さそうです
次行のような各 Actions についても，セキュリティーの観点からバージョンは commit hash による指定が望ましいです。pinact のようなツールを使って機械的に置換すればサクッと対応できます。願わくば Renovate を使ってこの更新管理も自動化できるとなお良しではあるものの，流石にそこは本件の範囲外といったところでしょうかね……。
Suggested change
| - name: Checkout main branch | |
| uses: actions/checkout@v4 | |
| - name: Checkout target branch | |
| uses: actions/checkout@ # commit hash に置き換える |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub ActionsでPRの作成時に以下の4つをチェックするCIを追加