-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIの導入 #19
Merged
Merged
CIの導入 #19
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8475313
feat: add lint check on create pr
newt239 a5eeb91
chore: update eslint config
newt239 fb5fd33
fix:typo in import/order config
newt239 ad97502
fix: suppress warning no file matched on eslint
newt239 3a48566
fix: eslint config and run linter
newt239 d8f8f16
docs: improve task name
newt239 65e0363
feat: pin the version of github actions by using pinact
newt239 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: Lint Code Base | ||
on: | ||
pull_request: | ||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout main branch | ||
uses: actions/checkout@v4 | ||
- name: Setup Node | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: lts/* | ||
- name: Setup pnpm | ||
uses: pnpm/action-setup@v4 | ||
with: | ||
version: 9 | ||
- name: Install dependencies | ||
run: pnpm install | ||
- name: TypeScript Compile Check | ||
run: pnpm tsc --noEmit | ||
- name: Run ESLint | ||
run: pnpm lint | ||
- name: Run Prettier | ||
run: pnpm format --check | ||
- name: Run Stylelint | ||
run: pnpm stylelint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 行目について,PR の base branch に対しても実行されることを考えると「Checkout main branch」の「main」を「target」のような表現に変えてみるのはどうでしょうか? それなら意図が一層明瞭になって良さそうです
次行のような各 Actions についても,セキュリティーの観点からバージョンは commit hash による指定が望ましいです。pinact のようなツールを使って機械的に置換すればサクッと対応できます。願わくば Renovate を使ってこの更新管理も自動化できるとなお良しではあるものの,流石にそこは本件の範囲外といったところでしょうかね……。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
どちらも納得です、対応します!