-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to bulk save. #681
Move to bulk save. #681
Conversation
Thanks for the contribution! Unfortunately we can't verify the commit author(s): jjbennett <j***@j***.i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a look this morning, nice job. I think we'll need to get the test coverage to 100%.
@@ -186,6 +186,14 @@ const handleError = (error, fireShowToast = true, showToastMode, returnAsArray) | |||
message = error.body.map(e => e.message).join(", "); | |||
} else if (error.body && typeof error.body.message === "string") { | |||
message = error.body.message; | |||
} else if (Array.isArray(error)) { | |||
// databse save result errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: databse -> database.
@@ -33,6 +33,20 @@ public with sharing class ServiceDeliveryController { | |||
return true; | |||
} | |||
|
|||
@AuraEnabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting to see an Apex Test update in this PR based on this change. Same with the change to the domain class.
Thanks Tarren for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review feedback updates, Jenny!
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Asteroids DoD document to see any additional details for the items below