Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix unlimit delete_txn_log request from FE side #54857

Merged
merged 4 commits into from
Jan 13, 2025
Merged

[BugFix] Fix unlimit delete_txn_log request from FE side #54857

merged 4 commits into from
Jan 13, 2025

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Jan 9, 2025 •
edited
Loading

Why I'm doing:

In share data mode, if we use batch publish, when the publish is finished, a deleteTxnLog task will be send
to BE from a thread pool. But in current impl, we just send the RPC request but not wait for its finishing.
It makes that many bthread stack of deleteTxnLog will be accumulated in BE side and if hit the limit max_map_count
of operation system, BE will completely stuck.

What I'm doing:

Wait the rpc call finished in thread pool

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@srlch
[BugFix] Fix unlimit delete_txn_log request from FE side
30d3f0d 
Signed-off-by: srlch <linzichao@starrocks.com>
@srlch srlch requested a review from a team as a code owner January 9, 2025 03:03
@mergify mergify bot assigned srlch Jan 9, 2025
luohaha
luohaha previously approved these changes Jan 9, 2025
View reviewed changes
@srlch
fix
555650e 
Signed-off-by: srlch <linzichao@starrocks.com>
srlch added 2 commits January 10, 2025 17:05
@srlch
fix
c49d83a 
Signed-off-by: srlch <linzichao@starrocks.com>
@srlch
fix
054b2c3 
Signed-off-by: srlch <linzichao@starrocks.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 3 / 4 (75.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/PublishVersionDaemon.java 3 4 75.00% [573]

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb enabled auto-merge (squash) January 13, 2025 05:46
@andyziye andyziye disabled auto-merge January 13, 2025 06:08
@andyziye andyziye merged commit a6b14d7 into StarRocks:main Jan 13, 2025
51 of 53 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 13, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 13, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 13, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 13, 2025
@srlch @mergify
[BugFix] Fix unlimit delete_txn_log request from FE side (#54857)
9fa808c 
Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit a6b14d7)
@mergify mergify bot mentioned this pull request Jan 13, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 13, 2025
@srlch @mergify
[BugFix] Fix unlimit delete_txn_log request from FE side (#54857)
036098b 
Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit a6b14d7)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/transaction/PublishVersionDaemon.java
@mergify mergify bot mentioned this pull request Jan 13, 2025
Closed
18 tasks
srlch added a commit to srlch/starrocks that referenced this pull request Jan 13, 2025
@srlch
[BugFix] Fix unlimit delete_txn_log request from FE side (backport St…
a797fd6 
…arRocks#54857)

Signed-off-by: srlch <linzichao@starrocks.com>
srlch added a commit to srlch/starrocks that referenced this pull request Jan 13, 2025
@srlch
[BugFix] Fix unlimit delete_txn_log request from FE side (backport St…
65f5438 
…arRocks#54857)

Signed-off-by: srlch <linzichao@starrocks.com>
luohaha pushed a commit that referenced this pull request Jan 13, 2025
@srlch
[BugFix] Fix unlimit delete_txn_log request from FE side (backport #5…
02a22ce 
…4857) (#54991)

Signed-off-by: srlch <linzichao@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 13, 2025
@mergify @srlch
[BugFix] Fix unlimit delete_txn_log request from FE side (backport #5…
5492f58 
…4857) (#54986)

Co-authored-by: srlch <111035020+srlch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@wyb wyb wyb approved these changes

@luohaha luohaha luohaha left review comments

Assignees

@srlch srlch

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srlch @wyb @luohaha @gengjun-git @andyziye