Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix unlimit delete_txn_log request from FE side (backport #54857) #54986

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 13, 2025

Why I'm doing:

In share data mode, if we use batch publish, when the publish is finished, a deleteTxnLog task will be send
to BE from a thread pool. But in current impl, we just send the RPC request but not wait for its finishing.
It makes that many bthread stack of deleteTxnLog will be accumulated in BE side and if hit the limit max_map_count
of operation system, BE will completely stuck.

What I'm doing:

Wait the rpc call finished in thread pool

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit a6b14d7)
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@wanpengfei-git wanpengfei-git merged commit 5492f58 into branch-3.4 Jan 13, 2025
34 of 36 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-54857 branch January 13, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants