-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Cosign Sign #2633
base: main
Are you sure you want to change the base?
Add: Cosign Sign #2633
Conversation
|
||
- name: Upload jar binaries to release | ||
- name: Upload binaries, attestations and signatures to release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid using an external action to upload binaries. Gh CLI is already available inside GH runner, you can use something like (haven't tested it but should be close to that)
https://cli.github.com/manual/gh_release_upload
- name: Upload artifact to release
run: gh release upload ${{ github.ref }} ./build/libs/Stirling-PDF${{ matrix.file_suffix }}.* ./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.*
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@M0NsTeRRR I have the signature created in the cosign attest-blob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to have at least a single job that verifies every artifact is properly signed using GitHub keyless signing (https://docs.sigstore.dev/cosign/verifying/attestation/).
Otherwise, except for my two other comments that were marked as resolved, it looks good to me! :)
Description
@M0NsTeRRR Can you check the correctness
Checklist