Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Cosign Sign #2633

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Add: Cosign Sign #2633

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2624b99
Add: Cosign with OIDC
Ludy87 Jan 7, 2025
d70674f
Update releaseArtifacts.yml
Ludy87 Jan 7, 2025
4e2f304
Update releaseArtifacts.yml
Ludy87 Jan 8, 2025
14930f0
Merge branch 'main' into sign_release
Ludy87 Jan 8, 2025
e433a5d
Update releaseArtifacts.yml
Ludy87 Jan 9, 2025
ec61215
Merge branch 'main' into sign_release
Ludy87 Jan 9, 2025
50be6e9
Merge branch 'main' into sign_release
Ludy87 Jan 9, 2025
aec949f
Update releaseArtifacts.yml
Ludy87 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 51 additions & 27 deletions .github/workflows/releaseArtifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
permissions:
contents: write
Ludy87 marked this conversation as resolved.
Show resolved Hide resolved
packages: write
id-token: write
attestations: write
Ludy87 marked this conversation as resolved.
Show resolved Hide resolved
strategy:
matrix:
enable_security: [true, false]
Expand Down Expand Up @@ -48,38 +50,60 @@ jobs:

- name: Get version number
id: versionNumber
run: echo "versionNumber=$(./gradlew printVersion --quiet | tail -1)" >> $GITHUB_OUTPUT
run: |
VERSION=$(grep "^version =" build.gradle | awk -F'"' '{print $2}')
echo "versionNumber=$VERSION" >> $GITHUB_OUTPUT

- name: Rename binarie
run: cp ./build/launch4j/Stirling-PDF.exe ./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.exe
- name: Rename binaries
run: |
cp ./build/launch4j/Stirling-PDF.exe ./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.exe
cp ./build/libs/Stirling-PDF-${{ steps.versionNumber.outputs.versionNumber }}.jar ./build/libs/Stirling-PDF${{ matrix.file_suffix }}.jar

- name: Upload Assets binarie
uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
with:
path: ./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.exe
name: Stirling-PDF-Server${{ matrix.file_suffix }}.exe
overwrite: true
retention-days: 1
if-no-files-found: error
- name: Install Cosign
uses: sigstore/cosign-installer@dc72c7d5c4d10cd6bcb8cf6e3fd625a9e5e537da # v3.7.0

- name: Upload binaries to release
uses: softprops/action-gh-release@01570a1f39cb168c169c802c3bceb9e93fb10974 # v2.1.0
with:
files: ./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.exe
- name: Sign JAR with Cosign OIDC
run: |
cosign sign-blob \
--yes \
--oidc-client-id sigstore \
--oidc-issuer https://token.actions.githubusercontent.com \
./build/libs/Stirling-PDF${{ matrix.file_suffix }}.jar \
> ./build/libs/Stirling-PDF${{ matrix.file_suffix }}.jar.sig
Ludy87 marked this conversation as resolved.
Show resolved Hide resolved

- name: Rename jar binaries
run: cp ./build/libs/Stirling-PDF-${{ steps.versionNumber.outputs.versionNumber }}.jar ./build/libs/Stirling-PDF${{ matrix.file_suffix }}.jar
- name: Sign EXE with Cosign OIDC
run: |
cosign sign-blob \
--yes \
--oidc-client-id sigstore \
--oidc-issuer https://token.actions.githubusercontent.com \
./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.exe \
> ./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.exe.sig

- name: Upload Assets jar binaries
uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b # v4.5.0
with:
path: ./build/libs/Stirling-PDF${{ matrix.file_suffix }}.jar
name: Stirling-PDF${{ matrix.file_suffix }}.jar
overwrite: true
retention-days: 1
if-no-files-found: error
- name: Generate Attestations for JAR
run: |
cosign attest-blob \
Ludy87 marked this conversation as resolved.
Show resolved Hide resolved
--predicate - \
--yes \
--oidc-client-id sigstore \
--oidc-issuer https://token.actions.githubusercontent.com \
./build/libs/Stirling-PDF${{ matrix.file_suffix }}.jar \
> ./build/libs/Stirling-PDF${{ matrix.file_suffix }}.jar.intoto.jsonl

- name: Generate Attestations for EXE
run: |
cosign attest-blob \
--predicate - \
--yes \
--oidc-client-id sigstore \
--oidc-issuer https://token.actions.githubusercontent.com \
./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.exe \
> ./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.exe.intoto.jsonl

- name: Upload jar binaries to release
- name: Upload binaries, attestations and signatures to release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid using an external action to upload binaries. Gh CLI is already available inside GH runner, you can use something like (haven't tested it but should be close to that)
https://cli.github.com/manual/gh_release_upload

 - name: Upload artifact to release
   run: gh release upload ${{ github.ref }} ./build/libs/Stirling-PDF${{ matrix.file_suffix }}.* ./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.*
   env:
     GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

uses: softprops/action-gh-release@01570a1f39cb168c169c802c3bceb9e93fb10974 # v2.1.0
with:
files: ./build/libs/Stirling-PDF${{ matrix.file_suffix }}.jar
tag_name: v${{ steps.versionNumber.outputs.versionNumber }}
files: |
./build/libs/Stirling-PDF${{ matrix.file_suffix }}.*
./build/launch4j/Stirling-PDF-Server${{ matrix.file_suffix }}.*
Loading