Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 GetMyUserInfoResponse - display ν•„λ“œ μΆ”κ°€ #33

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

waterfogSW
Copy link
Member

@waterfogSW waterfogSW commented Nov 17, 2024

Summary by CodeRabbit

  • μƒˆλ‘œμš΄ κΈ°λŠ₯
    • μ‚¬μš©μž ν”„λ‘œν•„ 정보λ₯Ό 더 μƒμ„Έν•˜κ²Œ ν‘œν˜„ν•˜λŠ” UserProfileDisplayInfo μŠ€ν‚€λ§ˆ μΆ”κ°€.
    • 직업 및 νšŒμ‚¬μ— λŒ€ν•œ 정보λ₯Ό μ œκ³΅ν•˜λŠ” JobOccupationDisplayInfo 및 CompanyDisplayInfo μŠ€ν‚€λ§ˆ μΆ”κ°€.
    • μœ„μΉ˜ 정보λ₯Ό μœ„ν•œ LocationDisplayInfo μŠ€ν‚€λ§ˆ μΆ”κ°€.
  • λ³€κ²½ 사항
    • μ‚¬μš©μž 정보 응닡 μŠ€ν‚€λ§ˆμ—μ„œ ν”„λ‘œν•„ μ°Έμ‘°κ°€ μƒˆλ‘œμš΄ μŠ€ν‚€λ§ˆλ‘œ μ—…λ°μ΄νŠΈλ¨.

Copy link

coderabbitai bot commented Nov 17, 2024

Walkthrough

이 λ³€κ²½ 사항은 3days API의 OpenAPI 사양에 μ—¬λŸ¬ 가지 μˆ˜μ •μ„ λ„μž…ν•©λ‹ˆλ‹€. μƒˆλ‘œμš΄ μŠ€ν‚€λ§ˆ UserProfileDisplayInfoκ°€ μΆ”κ°€λ˜μ–΄ GetMyUserInfoResponse와 UpdateMyUserInfoResponse μŠ€ν‚€λ§ˆμ—μ„œ μ΄μ „μ˜ UserProfile μ°Έμ‘°λ₯Ό λŒ€μ²΄ν•©λ‹ˆλ‹€. 이 μŠ€ν‚€λ§ˆλŠ” company와 locations와 같은 μΆ”κ°€ 속성을 ν¬ν•¨ν•˜μ—¬ μ‚¬μš©μž ν”„λ‘œν•„ μ •λ³΄μ˜ μ„ΈλΆ€ 사항을 ν–₯μƒμ‹œν‚΅λ‹ˆλ‹€. λ˜ν•œ, JobOccupationDisplayInfo 및 CompanyDisplayInfo μŠ€ν‚€λ§ˆκ°€ λ„μž…λ˜μ–΄ 직업 및 νšŒμ‚¬μ— λŒ€ν•œ κ΅¬μ‘°ν™”λœ 정보λ₯Ό μ œκ³΅ν•©λ‹ˆλ‹€.

Changes

파일 경둜 λ³€κ²½ μš”μ•½
openapi.yaml - μƒˆλ‘œμš΄ μŠ€ν‚€λ§ˆ UserProfileDisplayInfo, CompanyDisplayInfo, JobOccupationDisplayInfo, LocationDisplayInfo μΆ”κ°€
- GetMyUserInfoResponse 및 UpdateMyUserInfoResponseμ—μ„œ UserProfile μ°Έμ‘°λ₯Ό UserProfileDisplayInfo둜 μ—…λ°μ΄νŠΈ

Possibly related PRs

  • ✨ 직업 API μΆ”κ°€ 및 νƒœκ·Έ λΆ„λ₯˜ μˆ˜μ •Β #11: UserProfile μŠ€ν‚€λ§ˆμ˜ λ³€κ²½ 사항은 직업 μ‹λ³„μžμ™€ κ΄€λ ¨λœ 속성 μ—…λ°μ΄νŠΈλ₯Ό ν¬ν•¨ν•˜λ©°, μ΄λŠ” λ³Έ PRμ—μ„œ λ„μž…λœ JobOccupationDisplayInfo μŠ€ν‚€λ§ˆμ™€ 관련이 μžˆμ„ 수 μžˆμŠ΅λ‹ˆλ‹€.
  • ✨ νŒŒνŠΈλ„ˆ 직업ꡰ λ³΅μˆ˜μ„ νƒ κ°€λŠ₯ν•˜λ„λ‘ λ³€κ²½Β #18: 이 PR은 UserDesiredPartner μŠ€ν‚€λ§ˆλ₯Ό μˆ˜μ •ν•˜μ—¬ μ—¬λŸ¬ 직업 λΆ„λ₯˜λ₯Ό ν—ˆμš©ν•˜λ©°, μ΄λŠ” λ³Έ PR의 μƒˆλ‘œμš΄ 직업 κ΄€λ ¨ μŠ€ν‚€λ§ˆμ™€ μ—°κ²°λ©λ‹ˆλ‹€.
  • ✨ 직업ꡰ μˆ˜μ •Β #20: 이 PR의 JobOccupations μŠ€ν‚€λ§ˆ μ—…λ°μ΄νŠΈλŠ” 직업 λ²”μ£Ό 변경을 λ°˜μ˜ν•˜λ©°, μ΄λŠ” λ³Έ PRμ—μ„œ λ„μž…λœ JobOccupationDisplayInfo μŠ€ν‚€λ§ˆμ™€ 관련이 μžˆμ„ 수 μžˆμŠ΅λ‹ˆλ‹€.
  • ✨ μœ μ € ν”„λ‘œν•„ μˆ˜μ • api specμ •μ˜Β #31: 이 PRμ—μ„œ UpdateMyUserInfoRequest 및 UpdateMyUserInfoResponse μŠ€ν‚€λ§ˆμ˜ μΆ”κ°€λŠ” λ³Έ PR의 μ‚¬μš©μž ν”„λ‘œν•„ μŠ€ν‚€λ§ˆ μ—…λ°μ΄νŠΈμ™€ 관련이 있으며, 특히 μƒˆλ‘œμš΄ UserProfileDisplayInfo 참쑰와 관련이 μžˆμŠ΅λ‹ˆλ‹€.

Suggested labels

fix

Suggested reviewers

  • dojinyou
  • moondev03
  • jisu15-kim

πŸ‡ μƒˆλ‘œμš΄ μŠ€ν‚€λ§ˆκ°€ μ™”μ–΄μš”,
μ‚¬μš©μž 정보가 더 ν’λΆ€ν•΄μ Έμš”!
직업과 νšŒμ‚¬λ„ ν•¨κ»˜ν•΄,
ν”„λ‘œν•„μ΄ λ”μš± λΉ›λ‚˜μš”!
APIκ°€ ν•œμΈ΅ 더 λ˜‘λ˜‘ν•΄,
λͺ¨λ‘κ°€ 기뻐할 κ±°μ˜ˆμš”! ✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
openapi.yaml (1)

780-795: 예제 μΆ”κ°€ μ œμ•ˆ

λ‹€λ₯Έ μŠ€ν‚€λ§ˆλ“€μ²˜λŸΌ CompanyDisplayInfo에도 예제λ₯Ό μΆ”κ°€ν•˜λ©΄ API λ¬Έμ„œμ˜ 일관성과 이해도λ₯Ό 높일 수 μžˆμŠ΅λ‹ˆλ‹€.

       required:
         - id
         - display
+      example:
+        id: "0191cd0e-a061-7213-b39e-51274c1e7c71"
+        display: "CodeRabbit Inc."
πŸ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between aba707b and 01f2e63.

πŸ“’ Files selected for processing (1)
  • openapi.yaml (2 hunks)
πŸ”‡ Additional comments (4)
openapi.yaml (4)

756-779: ꡬ쑰가 잘 μ„€κ³„λ˜μ—ˆμŠ΅λ‹ˆλ‹€!

UserProfileDisplayInfo μŠ€ν‚€λ§ˆκ°€ λ‹€μŒκ³Ό 같은 μž₯점을 가지고 μžˆμŠ΅λ‹ˆλ‹€:

  • ν•„μˆ˜ ν•„λ“œκ°€ λͺ…ν™•ν•˜κ²Œ μ •μ˜λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€
  • 각 속성에 λŒ€ν•œ μ„€λͺ…이 λͺ…ν™•ν•©λ‹ˆλ‹€
  • κΈ°μ‘΄ UserProfile과의 ν•˜μœ„ ν˜Έν™˜μ„±μ„ μœ μ§€ν•˜λ©΄μ„œ ν‘œμ‹œμš© ν•„λ“œλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€

796-810: 잘 κ΅¬ν˜„λ˜μ—ˆμŠ΅λ‹ˆλ‹€!

JobOccupationDisplayInfo μŠ€ν‚€λ§ˆκ°€ κΈ°μ‘΄ JobOccupation enum을 잘 ν™œμš©ν•˜λ©΄μ„œ ν‘œμ‹œμš© ν•„λ“œλ₯Ό μΆ”κ°€ν–ˆκ³ , μ˜ˆμ œλ„ ν¬ν•¨λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.


811-827: 잘 κ΅¬ν˜„λ˜μ—ˆμŠ΅λ‹ˆλ‹€!

LocationDisplayInfo μŠ€ν‚€λ§ˆκ°€ λ‹€λ₯Έ display 정보 μŠ€ν‚€λ§ˆλ“€κ³Ό μΌκ΄€λœ ꡬ쑰λ₯Ό 가지고 있으며, μ˜ˆμ œλ„ ν¬ν•¨λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.


671-671: ⚠️ Potential issue

응닡 μŠ€ν‚€λ§ˆ κ°„ 일관성 κ²€ν†  ν•„μš”

GetMyUserInfoResponseλŠ” UserProfileDisplayInfoλ₯Ό μ‚¬μš©ν•˜λ„λ‘ λ³€κ²½λ˜μ—ˆμ§€λ§Œ, UpdateMyUserInfoResponseλŠ” μ—¬μ „νžˆ UserProfile을 μ°Έμ‘°ν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€. 두 μ‘λ‹΅μ˜ 일관성을 μœ„ν•΄ UpdateMyUserInfoResponse도 λ™μΌν•˜κ²Œ 변경이 ν•„μš”ν•΄ λ³΄μž…λ‹ˆλ‹€.

@waterfogSW waterfogSW merged commit 490eae1 into main Nov 17, 2024
3 checks passed
@waterfogSW waterfogSW deleted the feat/add-display-field branch November 17, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants