Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention that a log file with a fixed file name is always appended to #5

Merged

Conversation

dlaehnemann
Copy link
Contributor

This one tripped me up, as we are using our workflow management system (snakemake) to do the logging for us, but I also got these unexpected log files in the results directory. Also, I initially got confused by old error output before I realized that the log file is not cleared before writing new stuff. So it accumulates the logging output of multiple runs with the same data. As a minimal fix, this PR includes this info in the docs.

@priesgo
Copy link
Collaborator

priesgo commented Sep 9, 2022

Thanks @dlaehnemann, Just reported this one #7

Copy link
Collaborator

@priesgo priesgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priesgo priesgo merged commit 5b34510 into TRON-Bioinformatics:develop Sep 9, 2022
@dlaehnemann
Copy link
Contributor Author

Thanks @dlaehnemann, Just reported this one #7

Wasn't sure if this was intended behaviour in your usage setting, so I just added the info to the docs and didn't attempt a fix. But good to see this followed up, thanks!

priesgo added a commit that referenced this pull request Nov 27, 2023
docs: mention that a log file with a fixed file name is always appended to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants