Optimize TickMath
#273
Closed
Optimize TickMath
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 18, 2023
|
Please accept this pull request @snreynolds |
|
Hey @shuhuiluo ! We're finally going through our final stages of development so are considering all your optimisations now 🙏 sorry for the delay here! Would you mind please merging in main and updating the gas snapshots please so we can see what the new values would be? |
Will do. |
# Conflicts: # .forge-snapshots/initialize.snap # .forge-snapshots/mint with empty hook.snap # .forge-snapshots/mint with native token.snap # .forge-snapshots/mint.snap # .forge-snapshots/simple swap.snap # .forge-snapshots/swap against liquidity with native token.snap # .forge-snapshots/swap against liquidity.snap # .forge-snapshots/swap with hooks.snap # .forge-snapshots/swap with native.snap # test/TickMath.spec.ts # test/__snapshots__/PoolManager.gas.spec.ts.snap # test/__snapshots__/PoolManager.spec.ts.snap # test/__snapshots__/Tick.spec.ts.snap # test/__snapshots__/TickMath.spec.ts.snap # test/libraries/TickMath.t.sol
# Conflicts: # .forge-snapshots/addLiquidity with empty hook.snap # .forge-snapshots/addLiquidity with native token.snap # .forge-snapshots/addLiquidity.snap # .forge-snapshots/initialize.snap # .forge-snapshots/poolManager bytecode size.snap # .forge-snapshots/removeLiquidity with empty hook.snap # .forge-snapshots/removeLiquidity with native token.snap # .forge-snapshots/removeLiquidity.snap # .forge-snapshots/simple swap with native.snap # .forge-snapshots/simple swap.snap # .forge-snapshots/swap against liquidity with native token.snap # .forge-snapshots/swap against liquidity.snap # .forge-snapshots/swap burn 6909 for input.snap # .forge-snapshots/swap burn native 6909 for input.snap # .forge-snapshots/swap mint native output as 6909.snap # .forge-snapshots/swap mint output as 6909.snap # .forge-snapshots/swap with dynamic fee.snap # .forge-snapshots/swap with hooks.snap # .forge-snapshots/update dynamic fee in before swap.snap # src/libraries/TickMath.sol
…is in two's complement This change replaces the shift right (`shr`) operation with the arithmetic shift right (`sar`) operation in the `getTickAtSqrtRatio` function of the `TickMath` library. The aim is to ensure the return value correctly reflects the underlying data representation in two's complement form. The change affects the variables `tickLow` and `tickHi` which store the results of these shifted operations.
This was referenced May 17, 2024
This was referenced May 18, 2024
…th.getTickAtSqrtPrice` This commit includes a major refactoring of the assembly code used to find the most significant bit of a given price in the TickMath.sol file. It replaced the bulky and repetitive lines of code with a more streamlined and condensed version from Solady.
A substantial rewriting of the calculation logic was performed in `TickMath.sol`, with a primary focus on the calculation method of the most significant bits of `sqrtPriceX96` and the int256 `log_2` value. It notably enhances precision by shifting left before right and makes use of floating-point math for approximation of `log_2`. It also removes unused variables and streamlines the assembly code to increase efficiency and readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of Changes
The
TickMathlibrary has undergone extensive annotation and optimization, with the implementation ported from Aperture-Finance/uni-v3-lib. The optimizations primarily focus on eliminating branching code that involves conditional statements. An inlined and more efficient version of themostSignificantBitfunction from Solady::LibBit has been incorporated, following its introduction in #257. Additional amendments have been made to reduce the number of opcodes and stack/memory operations.New Forge tests for
TickMathhave been added to affirm equivalence with the reference implementation and to allow comparisons of gas usage. Gas snapshots were taken both before and after the changes to evaluate the effectiveness of these optimizations. The results are as follows:Gas Usage Comparison
Note: Each test runs the corresponding function 100 times with deterministic inputs.