Remove indexed modifier from select fields #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forge code coverage:
|
|
thank you!!
|
codyborn
force-pushed
the
event_gas_optimizations
branch
from
5f81944 to
0e4fecb
Compare
snreynolds
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Saves ~100 gas on Swaps and Pool creation.
Removes the
indexedmodifier from thesenderin theSwapevent. This field is important for wallet providers but they will already have the transaction hash when sent by the user, which they can use to track the state change from this user.Removes the
indexedmodifier from theidin theInitializeevent. It doesn't make sense to index on this field since this is the first time that the PoolId will be created. Future events (Swap/ModifyLiquidity) can be filtered on this PoolId, but no one would be aware of the PoolId until the Initialize event is emitted.