Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove indexed modifier from select fields #595

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Remove indexed modifier from select fields #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd787c6
Remove index from fields
codyborn Apr 23, 2024
8634f30
forge fmt
codyborn Apr 24, 2024
0e4fecb
Merge main
codyborn Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .forge-snapshots/initialize.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
51288
51181
2 changes: 1 addition & 1 deletion .forge-snapshots/poolManager bytecode size.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22714
22732
2 changes: 1 addition & 1 deletion .forge-snapshots/simple swap with native.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
126904
126824
2 changes: 1 addition & 1 deletion .forge-snapshots/simple swap.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
138297
138217
2 changes: 1 addition & 1 deletion .forge-snapshots/swap against liquidity with native token.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
71199
71119
2 changes: 1 addition & 1 deletion .forge-snapshots/swap against liquidity.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
61518
61438
2 changes: 1 addition & 1 deletion .forge-snapshots/swap burn 6909 for input.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
79507
79427
2 changes: 1 addition & 1 deletion .forge-snapshots/swap burn native 6909 for input.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
75350
75270
2 changes: 1 addition & 1 deletion .forge-snapshots/swap mint native output as 6909.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
135637
135557
2 changes: 1 addition & 1 deletion .forge-snapshots/swap mint output as 6909.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
152300
152220
2 changes: 1 addition & 1 deletion .forge-snapshots/swap skips hook call if hook is caller.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
158919
158759
2 changes: 1 addition & 1 deletion .forge-snapshots/swap with dynamic fee.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
90787
90704
2 changes: 1 addition & 1 deletion .forge-snapshots/swap with hooks.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
61497
61417
2 changes: 1 addition & 1 deletion .forge-snapshots/swap with lp fee and protocol fee.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
151117
151034
2 changes: 1 addition & 1 deletion .forge-snapshots/update dynamic fee in before swap.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
131814
131731
9 changes: 2 additions & 7 deletions src/interfaces/IPoolManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,7 @@ interface IPoolManager is IProtocolFees, IERC6909Claims, IExtsload {
/// @param tickSpacing The minimum number of ticks between initialized ticks
/// @param hooks The hooks contract address for the pool, or address(0) if none
event Initialize(
PoolId indexed id,
Currency indexed currency0,
Currency indexed currency1,
uint24 fee,
int24 tickSpacing,
IHooks hooks
PoolId id, Currency indexed currency0, Currency indexed currency1, uint24 fee, int24 tickSpacing, IHooks hooks
);

/// @notice Emitted when a liquidity position is modified
Expand All @@ -77,7 +72,7 @@ interface IPoolManager is IProtocolFees, IERC6909Claims, IExtsload {
/// @param fee The swap fee in hundredths of a bip
event Swap(
PoolId indexed id,
address indexed sender,
address sender,
int128 amount0,
int128 amount1,
uint160 sqrtPriceX96,
Expand Down
2 changes: 1 addition & 1 deletion test/DynamicFees.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ contract TestDynamicFees is Test, Deployers, GasSnapshot {

event Swap(
PoolId indexed poolId,
address indexed sender,
address sender,
int128 amount0,
int128 amount1,
uint160 sqrtPriceX96,
Expand Down
2 changes: 1 addition & 1 deletion test/PoolManager.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ contract PoolManagerTest is Test, Deployers, GasSnapshot {
);
event Swap(
PoolId indexed poolId,
address indexed sender,
address sender,
int128 amount0,
int128 amount1,
uint160 sqrtPriceX96,
Expand Down
2 changes: 1 addition & 1 deletion test/PoolManagerInitialize.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ contract PoolManagerInitializeTest is Test, Deployers, GasSnapshot {
using ProtocolFeeLibrary for uint24;

event Initialize(
PoolId indexed poolId,
PoolId poolId,
Currency indexed currency0,
Currency indexed currency1,
uint24 fee,
Expand Down
Loading