-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve acronym function names #250
Improve acronym function names #250
Conversation
src/main/kotlin/org/virtuslab/pulumikotlin/codegen/utils/StringUtils.kt
Outdated
Show resolved
Hide resolved
062cfee
to
28b17f6
Compare
3f9e935
to
6087622
Compare
For the record, here is the list with "tricky" type/resource names for providers supported by Open the list
I'm wondering how we handle these:
|
The first two seem fine to me. |
I think it's weird, but there is probably nothing we could do about it now, so let's leave it as is.
Yep, I think that might be better actually. |
src/test/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiNameTest.kt
Show resolved
Hide resolved
1f06f98
to
8504482
Compare
8504482
to
b302703
Compare
28b17f6
to
3d03e16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a couple of minor comments, but feel free to merge now.
src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiName.kt
Show resolved
Hide resolved
src/main/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiName.kt
Show resolved
Hide resolved
src/test/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiNameTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/virtuslab/pulumikotlin/codegen/utils/StringUtilsKtTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/virtuslab/pulumikotlin/codegen/step2intermediate/PulumiNameTest.kt
Show resolved
Hide resolved
3d03e16
to
8e97914
Compare
b302703
to
529773a
Compare
Can't merge, because this is branched off of #241 ;) EDIT: That might be not necessary, not sure how many conflicts there would be. I might "unrebase" if I find some free time |
529773a
to
2c92ad6
Compare
Signed-off-by: Julia Plewa <jplewa@virtuslab.com>
Signed-off-by: Julia Plewa <jplewa@virtuslab.com>
Signed-off-by: Julia Plewa <jplewa@virtuslab.com>
Signed-off-by: Julia Plewa <jplewa@virtuslab.com>
d003004
to
a2991c9
Compare
Signed-off-by: Julia Plewa <jplewa@virtuslab.com>
a2991c9
to
27c924b
Compare
Task
Resolves: #221
Description
IAMBinding
->iamBinding
IamAuditConfig
->iamAuditConfig
OrganizationPolicy
->organizationPolicy
This one is a bit awkward, but it's not our fault they called it
VMware
instead ofVmware
:VMwareCluster
->vMwareCluster