Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a bar with the events to which the user contributes #114

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

amieiro
Copy link
Collaborator

@amieiro amieiro commented Feb 20, 2024

This PR adds a bar with the events to which the user contributes.

If the user contributes to up to 3 events, it displays all of them. If she contributes to more, it shows 2 and a text with the number of the other events to which he/she contributes.

User who does not attend any event

Translations   Galician   Akismet Anti-Spam   GlotPress 2024-02-20 11-21-07

User attending 1 event

Translations   Galician   Akismet Anti-Spam   GlotPress 2024-02-20 11-17-24

User attending 2 events

Translations   Galician   Akismet Anti-Spam   GlotPress 2024-02-20 11-16-46

User attending 3 events

Translations   Galician   Akismet Anti-Spam   GlotPress 2024-02-20 11-19-05

User attending more than 3 events

Translations   Galician   Akismet Anti-Spam   GlotPress 2024-02-20 11-20-02

This PR needs this PR to be approved.

Fixes #98.

Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll test this once the GlotPress PR gets merged.

wporg-gp-translation-events.php Show resolved Hide resolved
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, my only remark is that it looks a bit too much like a warning for my taste but I am curious for other opinions.

wporg-gp-translation-events.php Outdated Show resolved Hide resolved
wporg-gp-translation-events.php Show resolved Hide resolved
wporg-gp-translation-events.php Outdated Show resolved Hide resolved
@amieiro
Copy link
Collaborator Author

amieiro commented Feb 21, 2024

Nice, my only remark is that it looks a bit too much like a warning for my taste but I am curious for other opinions.

What about changing from --gp-color-attention-emphasis to --gp-color-status-waiting-subtle:

Current color

image

New color

image

@amieiro
Copy link
Collaborator Author

amieiro commented Feb 21, 2024

I have added the links to each event in the bubbles and a link to the main page in the "and 2 more events", because the user can see the "Event she is attending" in this page, and we don't have a page with only this information.

I have changed the background color to a lighter one. I prefer to use a GlotPress color, to avoid color inconsistencies if they are changed in the future.

@psrpinto the hook in GlotPress has been merged, so you can pull the develop branch from GlotPress and test it.

image

@amieiro amieiro requested review from psrpinto and akirk February 21, 2024 11:27
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well after pulling the latest develop branch of GlotPress. Maybe we can ask a designer later on to take another look at the styling, also in general of the plugin.

Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works 👌

@amieiro amieiro merged commit 3d9a550 into trunk Feb 21, 2024
2 checks passed
@amieiro amieiro deleted the contributing-active-events branch February 21, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show inside the translation process that there are active events
3 participants