Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2279] CI/CD: Add option to build debug wheels #508

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 11, 2023

Testing

Default (optimized): https://github.com/aerospike/aerospike-client-python/actions/runs/7977785567
Unoptimized: https://github.com/aerospike/aerospike-client-python/actions/runs/7977732104

Artifact file names:
Default (optimized): https://github.com/aerospike/aerospike-client-python/actions/runs/7977785567/job/21781461980#step:11:1137
Unoptimized: https://github.com/aerospike/aerospike-client-python/actions/runs/7977732104/job/21781278574#step:11:1144

Checked that compiler uses the right optimization flags for both optimized and unoptimized builds

Extra changes:

  • fix bug where windows artifacts aren't uploaded to JFrog

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2279-cicd-debug branch 4 times, most recently from fc8ebde to 3d017de Compare September 11, 2023 21:10
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88f92d2) 81.38% compared to head (90e2578) 81.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #508   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files          98       98           
  Lines       14911    14911           
=======================================
  Hits        12136    12136           
  Misses       2775     2775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2279-cicd-debug branch 7 times, most recently from 3295d5f to 1b5d294 Compare September 13, 2023 21:11
@juliannguyen4 juliannguyen4 marked this pull request as ready for review September 15, 2023 15:52
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine

dwelch-spike
dwelch-spike previously approved these changes Oct 17, 2023
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 20b7f52 into dev Feb 20, 2024
63 of 105 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2279-cicd-debug branch February 20, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants