-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-2279] CI/CD: Add option to build debug wheels #508
Conversation
fc8ebde
to
3d017de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #508 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 98 98
Lines 14911 14911
=======================================
Hits 12136 12136
Misses 2775 2775 ☔ View full report in Codecov by Sentry. |
3295d5f
to
1b5d294
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
1bda58d
to
0adeafc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look fine
b34ad9f
to
7218152
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
08b31d7
to
95ef334
Compare
7ab793a
to
0d97fc4
Compare
ca124a0
to
90e2578
Compare
90e2578
to
bd7224c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
Testing
Default (optimized): https://github.com/aerospike/aerospike-client-python/actions/runs/7977785567
Unoptimized: https://github.com/aerospike/aerospike-client-python/actions/runs/7977732104
Artifact file names:
Default (optimized): https://github.com/aerospike/aerospike-client-python/actions/runs/7977785567/job/21781461980#step:11:1137
Unoptimized: https://github.com/aerospike/aerospike-client-python/actions/runs/7977732104/job/21781278574#step:11:1144
Checked that compiler uses the right optimization flags for both optimized and unoptimized builds
Extra changes: