Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractional Knapsack Problem added (fixes #1912) #2003

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

laxmikandivalasa
Copy link
Contributor

📥 Pull Request

Description

To maximize profit by selecting items with weights and profits, allowing fractional items.

Fixes #1912

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • [ X] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes
  • [X ] Any dependent changes have been merged and published in downstream modules

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible.). If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

github-actions bot commented Nov 10, 2024

⚡️ Lighthouse Report for the Deploy Preview of this PR 🚀

🔗 Site: Algo | Live Site

URL 🌐 Performance Accessibility Best Practices SEO 📊
/algo/ 🟡 62 🟢 96 🟡 71 🟡 86 📄
/algo/docs 🔴 49 🟢 96 🟡 75 🟢 100 📄
/algo/blog 🟡 66 🟢 92 🟢 96 🟡 86 📄

@laxmikandivalasa
Copy link
Contributor Author

@ajay-dhangar can you check this pr!!

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels labels Nov 10, 2024
@laxmikandivalasa
Copy link
Contributor Author

@ajay-dhangar can't you merge this now??

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@laxmikandivalasa
Copy link
Contributor Author

@ajay-dhangar will this count in the leaderboard?

@ajay-dhangar
Copy link
Owner

@ajay-dhangar will this count in the leaderboard?

Yes

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@laxmikandivalasa
Copy link
Contributor Author

Thank you!

@laxmikandivalasa
Copy link
Contributor Author

laxmikandivalasa commented Nov 10, 2024

@ajay-dhangar What if the pending pr(for this pr) in the open source practice project is in open?

@laxmikandivalasa
Copy link
Contributor Author

laxmikandivalasa commented Nov 10, 2024

@ajay-dhangar can these prs get merged now??

@ajay-dhangar ajay-dhangar merged commit 89c3d55 into ajay-dhangar:main Nov 10, 2024
5 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #2003 has been merged! 🎉🎉

@laxmikandivalasa
Copy link
Contributor Author

@ajay-dhangar Will this get added in the leaderboard ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Idea]: Fractional Knapsack Problem
2 participants