[CALCITE-4199] Add nullability annotations to the methods and fields, ensure consistency with checkerframework #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
checkerframework
branch
from
0bd398b to
881330e
Compare
vlsi
force-pushed
the
checkerframework
branch
7 times, most recently
from
616ea37 to
ef72c8d
Compare
vlsi
force-pushed
the
checkerframework
branch
8 times, most recently
from
9a89cb1 to
d4c526a
Compare
…eName non-nullable
vlsi
force-pushed
the
checkerframework
branch
3 times, most recently
from
73be222 to
bcff3ec
Compare
The Checker Framework needs an annotated JDK, so it is not activated by default.
Please use the following command to execute the check (only linq4j and core modules are annotated for now):
./gradlew -PenableCheckerframework :linq4j:classes :core:classes
The code style is to use non-nullable types by default, so please refrain from explicit @nonnull.
Please use org.checkerframework.checker.** annotations rather than javax.annotation.**
vlsi
force-pushed
the
checkerframework
branch
from
bcff3ec to
390c7b6
Compare
The commit includes javadoc updates and refactorings made by Julian Hyde in apache#2278
Add private class PosBuilder to allow lists or arrays of positions to be summed without creating intermediate collections. Nullness is also more transparent.
vlsi
force-pushed
the
checkerframework
branch
from
390c7b6 to
3d13846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-4199
CheckerFramework needs an annotated JDK (which might be slow to download), so it is not activated by default
Third-party issues:
Corner cases:
if (queue.isEmpty()) { ... = queue.poll(); }, and it treatspoll()as always nullable.