-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more metrics for grafana dashboard #6870
Conversation
* dashboard * variable * revert
btw, I think we should keep the 1m trend interval, "x times per minute" is a very common concept |
test failure looks related to #6865 |
Some JVM panels seem does not work for Java17, which can be fixed later independently. |
This reverts commit 1067182.
4e26095
to
1f4be56
Compare
Also add total connections in the overview for multiple kyuubi instances use case, should be general. @pan3793 It should be almost done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6870 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 688 +1
Lines 42515 42545 +30
Branches 5799 5800 +1
======================================
- Misses 42515 42545 +30 ☔ View full report in Codecov by Sentry. |
e5dc795
to
1291941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified locally, thanks!
Merged to master |
Why are the changes needed?
Add more metrics for monitoring.
How was this patch tested?
2. Connection(repeat for connectionType -
thrift_binary_connection,rest_connection,thrift_http_connection,metadata_request
)For example:
ExecuteStatement,BatchJobSubmission,LaunchEngine
)Was this patch authored or co-authored using generative AI tooling?
No.