Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Node path to compile with appium 2 and make him cross-platform #659

Merged
merged 37 commits into from
Nov 13, 2023

Conversation

Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Oct 3, 2023

List of changes

appium.js Windows node path used in the integration tests has changed on appium 2.
This PR addresses the the issue and makes sure it's generic for all users and compiles with appium 2.
In addition, I made a small refactor: Moved Appium.js path retrieval to helpers.paths class

in theory, it should also fix one or more dotnet CI tests:
https://github.com/appium/dotnet-client/pull/650/checks

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples showing how they work and possible use cases. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

refactor: Move Appium.js path retrieval to helpers.paths class
test/integration/helpers/Paths.cs Outdated Show resolved Hide resolved
@Dor-bl Dor-bl marked this pull request as draft October 5, 2023 09:00
@Dor-bl Dor-bl changed the title fix: Update Windows Node path to compile with appium 2 fix: Update Node path to compile with appium 2 and make him cross-platform Oct 5, 2023
@Dor-bl Dor-bl requested a review from laolubenson November 11, 2023 21:24
@Dor-bl Dor-bl merged commit 80568b8 into appium:main Nov 13, 2023
2 checks passed
@Dor-bl Dor-bl deleted the Appiumjs_path branch November 18, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants