fix: Update Node path to compile with appium 2 and make him cross-platform

test/integration/Properties/Resources.resx

@@ -118,15 +118,6 @@
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
   <assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
-  <data name="PathToLinuxNode" type="System.Resources.ResXFileRef, System.Windows.Forms">
-    <value>..\helpers\PathToLinuxNode;System.Byte[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
-  </data>
-  <data name="PathToMacOSNode" type="System.Resources.ResXFileRef, System.Windows.Forms">
-    <value>..\helpers\PathToMacOSNode;System.Byte[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
-  </data>
-  <data name="PathToWindowsNode" type="System.Resources.ResXFileRef, System.Windows.Forms">
-    <value>..\helpers\PathToWindowsNode;System.Byte[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
-  </data>
   <data name="ApiDemos_debug" type="System.Resources.ResXFileRef, System.Windows.Forms">
     <value>..\apps\ApiDemos-debug.apk;System.Byte[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </data>

test/integration/ServerTests/AppiumLocalServerLaunchingTest.cs

@@ -4,9 +4,8 @@
 using System.Net;
 using System.Text;
 using System.Threading;
-using Appium.Net.Integration.Tests.Properties;
+using Appium.Net.Integration.Tests.Helpers;
 using NUnit.Framework;
-using OpenQA.Selenium;
 using OpenQA.Selenium.Appium;
 using OpenQA.Selenium.Appium.Enums;
 using OpenQA.Selenium.Appium.Service;
@@ -18,15 +17,12 @@ namespace Appium.Net.Integration.Tests.ServerTests
     [TestFixture]
     public class AppiumLocalServerLaunchingTest
     {
-        private string _pathToCustomizedAppiumJs;
+        private string _pathToAppiumPackageIndex;
         private string _testIp;
 
         [OneTimeSetUp]
         public void BeforeAll()
         {
-            var isWindows = Platform.CurrentPlatform.IsPlatformType(PlatformType.Windows);
-            var isMacOs = Platform.CurrentPlatform.IsPlatformType(PlatformType.Mac);
-            var isLinux = Platform.CurrentPlatform.IsPlatformType(PlatformType.Linux);
 
             IPHostEntry host;
             var hostName = Dns.GetHostName();
@@ -41,25 +37,7 @@ public void BeforeAll()
             }
             Console.WriteLine(_testIp);
 
-            byte[] bytes;
-            if (isWindows)
-            {
-                bytes = Resources.PathToWindowsNode;
-                _pathToCustomizedAppiumJs = Encoding.UTF8.GetString(bytes);
-                return;
-            }
-            if (isMacOs)
-            {
-                bytes = Resources.PathToMacOSNode;
-                _pathToCustomizedAppiumJs = Encoding.UTF8.GetString(bytes);
-                return;
-            }
-            if (isLinux)
-            {
-                bytes = Resources.PathToLinuxNode;
-                _pathToCustomizedAppiumJs = Encoding.UTF8.GetString(bytes);
-                return;
-            }
+            _pathToAppiumPackageIndex = new Paths().PathToAppiumPackageIndex;
         }
 
         [Test]
@@ -105,7 +83,7 @@ public void CheckAbilityToBuildServiceUsingNodeDefinedInProperties()
             AppiumLocalService service = null;
             try
             {
-                var definedNode = _pathToCustomizedAppiumJs;
+                var definedNode = _pathToAppiumPackageIndex;
                 Environment.SetEnvironmentVariable(AppiumServiceConstants.AppiumBinaryPath, definedNode);
                 service = AppiumLocalService.BuildDefaultService();
                 service.Start();
@@ -124,7 +102,7 @@ public void CheckAbilityToBuildServiceUsingNodeDefinedExplicitly()
             AppiumLocalService service = null;
             try
             {
-                service = new AppiumServiceBuilder().WithAppiumJS(new FileInfo(_pathToCustomizedAppiumJs)).Build();
+                service = new AppiumServiceBuilder().WithAppiumJS(new FileInfo(_pathToAppiumPackageIndex)).Build();
                 service.Start();
                 Assert.AreEqual(true, service.IsRunning);
             }

test/integration/helpers/Npm.cs

@@ -0,0 +1,93 @@
+using System;
+using System.ComponentModel;
+using System.Diagnostics;
+using System.Linq;
+
+namespace Appium.Net.Integration.Tests.helpers
+{
+    internal class Npm
+    {
+
+        public static string GetNpmPrefixPath()
+        {
+            string npmPath = GetNpmExecutablePath();
+            string npmPrefixPath = RunCommand(npmPath, "-g root");
+
+            return npmPrefixPath.Trim();
+        }
+
+        private static string RunCommand(string command, string arguments, int timeoutMilliseconds = 30000)
+        {
+            int exitCode;
+            string output;
+            try
+            {
+                using (Process process = new Process
+                {
+                    StartInfo = new ProcessStartInfo
+                    {
+                        FileName = command,
+                        Arguments = arguments,
+                        RedirectStandardOutput = true,
+                        RedirectStandardError = true,
+                        UseShellExecute = false,
+                        CreateNoWindow = true,
+                    }
+                })
+                {
+                    process.Start();
+
+                    output = process.StandardOutput.ReadToEnd();
+                    string errorOutput = process.StandardError.ReadToEnd();
+                    _ = process.WaitForExit(timeoutMilliseconds);
+
+                    exitCode = process.ExitCode;
+                }
+                if ((exitCode == 1) && command.Contains("npm"))
+                {
+                    Console.WriteLine($"npm Error upon command: `{arguments}`. {output}");
+                    throw new NpmUnknownCommandException($"Command: `{arguments}` exited with code {exitCode}. Error: {output}");
+                }
+
+                return output;
+            }
+
+            catch (Win32Exception ex) when (command.Contains("npm"))
+            {
+                Console.WriteLine(ex.Message);
+                throw new NpmNotFoundException($"npm not found under {command}", ex);
+            }
+        }
+
+        private static string GetNpmExecutablePath()
+        {
+            string commandName = IsWindows() ? "where" : "which";
+            string result = RunCommand(commandName, "npm");
+
+            string npmPath;
+
+            string[] lines = result?.Split(new[] { Environment.NewLine }, StringSplitOptions.RemoveEmptyEntries);
+
+            if (IsWindows())
+            {
+                npmPath = lines?.FirstOrDefault(line => !string.IsNullOrWhiteSpace(line) && line.EndsWith("npm.cmd"));
+            }
+            else
+            {
+                npmPath = lines?.FirstOrDefault(line => !string.IsNullOrWhiteSpace(line));
+            }
+
+            if (string.IsNullOrWhiteSpace(npmPath))
+            {
+                throw new NpmNotFoundException("NPM executable not found. Please make sure the NPM executable is installed and check the configured PATH environment variable.");
+            }
+
+            return npmPath;
+        }
+
+        private static bool IsWindows()
+        {
+            return Environment.OSVersion.Platform == PlatformID.Win32NT;
+        }
+    }
+}

test/integration/helpers/NpmNotFoundException.cs

@@ -0,0 +1,22 @@
+using System;
+
+namespace Appium.Net.Integration.Tests.helpers
+{
+    public class NpmNotFoundException : Exception
+    {
+        public NpmNotFoundException()
+            : base("Node Package Manager (npm) cannot be found. Make sure Node.js is installed and present in PATH.")
+        {
+        }
+
+        public NpmNotFoundException(string message)
+            : base(message)
+        {
+        }
+
+        public NpmNotFoundException(string message, Exception innerException)
+        : base(message, innerException)
+        {
+        }
+    }
+}

test/integration/helpers/NpmUnknownCommandException.cs

@@ -0,0 +1,17 @@
+using System;
+
+namespace Appium.Net.Integration.Tests.helpers
+{
+    public class NpmUnknownCommandException : Exception
+    {
+        public NpmUnknownCommandException()
+            : base("Unknown npm command encountered. ")
+        {
+        }
+
+        public NpmUnknownCommandException(string message)
+            : base(message)
+        {
+        }
+    }
+}

test/integration/helpers/Paths.cs

@@ -0,0 +1,36 @@
+using Appium.Net.Integration.Tests.helpers;
+using System.IO;
+
+namespace Appium.Net.Integration.Tests.Helpers
+{
+    internal class Paths
+    {
+        private string _pathToAppiumPackageIndex;
+
+        public string PathToAppiumPackageIndex
+        {
+            get
+            {
+                if (_pathToAppiumPackageIndex == null)
+                {
+                    InitAppiumPackageIndexPath();
+                }
+                return _pathToAppiumPackageIndex;
+            }
+        }
+
+        /// <summary>
+        /// Initializes the Appium package index path by combining the components "appium" and "index.js" with the npm prefix path.
+        /// </summary>
+        /// <remarks>
+        /// This method sets the _pathToAppiumPackageIndex variable by combining the specified components with the npm prefix path.
+        /// </remarks>
+        private void InitAppiumPackageIndexPath()
+        {
+            string[] appiumJsPathComponents = { "appium", "index.js" }; 
+            string npmPath = Npm.GetNpmPrefixPath();
+
+            _pathToAppiumPackageIndex = Path.Combine(npmPath, Path.Combine(appiumJsPathComponents));
+        }
+    }
+}