-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add road regeneration and pretraining #9
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be nicer to use the gym register method instead of removing it?
In my own code I'm now using
from gym.envs.registration import register
register(
id='donkey-v0',
entry_point='donkey_gym.envs:DonkeyEnv',
timestep_limit=2000,
)
and then in the code part where I learn the RL algorithm, I pass arguments to the gym.make
command to init the env with the desired simulator level and vae object (or None if not using vae) like env = gym.make('donkey-v0', vae=vae, level=3)
By the way; great repo! ;)
Good point, in fact this is a recent addition to gym, this feature was missing for a long time, hence i was not using the make function. |
+ bug fixes + save best VAE model
TODO: tune pretraining