Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aoc-collector non-root user]: Create and use a new user for the container image #2301

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

PaurushGarg
Copy link
Member

Description:

This change is cherry-picked from dev branch commit: bc5fb1c8

Adding aoc user to docker file for dev branch as done in this PR.
Haven't removed RUN_IN_CONTAINER environment variable as it is getting used at this place as well.

Link to tracking Issue:
#2222

Testing:

Documentation:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@PaurushGarg PaurushGarg requested a review from a team as a code owner August 29, 2023 16:25
@PaurushGarg PaurushGarg requested a review from rapphil August 29, 2023 16:26
rapphil
rapphil previously requested changes Sep 5, 2023
Copy link
Member

@rapphil rapphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this change until we are ready to merge it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

This PR is stale because it has been open 30 days with no activity.

@bryan-aguilar bryan-aguilar dismissed rapphil’s stale review October 20, 2023 22:59

Approved, ready to merge

…ainer image (#2260)

* Create and use a new user for the container image

* Removing typo from dockerfile
Removing changes to ECS deployment template
@PaurushGarg PaurushGarg merged commit 7f21d16 into main Oct 21, 2023
27 checks passed
@PaurushGarg PaurushGarg deleted the non-root-user-image branch October 21, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants