feat(api,api-sdk): add getGroupsByAdminId() and getGroupsByMemberId() #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vplasencia
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Hey @waddaboo I just added one comment.
Great job. Very clean work 🙏
The dev branch has an issue now. Can you add these changes to a new branch to merge it into main so that these new features can be released right after the PR is merged?
Comment on lines
+821
to
+824
| where = { | ||
| adminId: filters.adminId, | ||
| ...where | ||
| } |
There was a problem hiding this comment.
Suggested change
| where = { | |
| adminId: filters.adminId, | |
| ...where | |
| } | |
| where = { | |
| adminId: filters.adminId | |
| } |
The where is not necessary here, right?
There was a problem hiding this comment.
Right, I'll take it away.
Sure! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new
api-sdkfeatures that allows users to get groups based onadminIdandmemberId.Related Issue
close #493
Does this introduce a breaking change?
Other information
https://github.com/waddaboo/bandada/blob/bea35ed9f1c290c1cb2b1267950c68f2002ae37a/apps/api/src/app/groups/groups.service.ts#L818-L825
Changed
wherefrom array to object so that it will return results forANDinstead ofORwhen bothadminIdandmemberIdis present in the query.