bump hail to 0.2.128 #3930
Merged
bump hail to 0.2.128 #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklugherz
commented
Feb 29, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM hailgenetics/hail:0.2.126 | |||
| FROM hailgenetics/hail:0.2.128 | |||
There was a problem hiding this comment.
will I need to create a requirements file and include google-cloud-storage as a dependency?
There was a problem hiding this comment.
I hope not? This docker image should never be interacting with cloud storage
hanars
requested changes
Feb 29, 2024
hail_search/requirements-test.in
Outdated
| @@ -1,2 +1,3 @@ | |||
| coverage<5.2 | |||
| pytest-aiohttp | |||
| google-cloud-storage>=2.14.0 | |||
There was a problem hiding this comment.
what in the hail search tests relies on cloud storage? The tests were passing before this commit, and I don't think its necessary to add this dependency
There was a problem hiding this comment.
Yeah, I don't think we need this dependency on the seqr side. This dependency is our gencode download in the pipeline.
There was a problem hiding this comment.
oh I was literally looking at a unit test run from another repo, my bad I'll remove this
hanars
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.