Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hail to 0.2.128 #3930

Merged
merged 5 commits into from
Feb 29, 2024
Merged

bump hail to 0.2.128 #3930

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3a79a3
bump hail to 0.2.128
jklugherz Feb 29, 2024
af3d3ae
google cloud storage
jklugherz Feb 29, 2024
886e2ea
Revert "bump hail to 0.2.128"
jklugherz Feb 29, 2024
34674a9
bump hail to 0.2.128
jklugherz Feb 29, 2024
9bebaee
Revert "google cloud storage"
jklugherz Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/hail-search-unit-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:
jobs:
hail_search:
runs-on: ubuntu-latest
container: hailgenetics/hail:0.2.126
container: hailgenetics/hail:0.2.128

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion hail_search/deploy/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM hailgenetics/hail:0.2.126
FROM hailgenetics/hail:0.2.128

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will I need to create a requirements file and include google-cloud-storage as a dependency?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope not? This docker image should never be interacting with cloud storage

LABEL maintainer="Broad TGG"

Expand Down
1 change: 1 addition & 0 deletions hail_search/requirements-test.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
coverage<5.2
pytest-aiohttp
google-cloud-storage>=2.14.0
Copy link
Collaborator

@hanars hanars Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what in the hail search tests relies on cloud storage? The tests were passing before this commit, and I don't think its necessary to add this dependency

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think we need this dependency on the seqr side. This dependency is our gencode download in the pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I was literally looking at a unit test run from another repo, my bad I'll remove this

53 changes: 50 additions & 3 deletions hail_search/requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#
# This file is autogenerated by pip-compile with Python 3.9
# To update, run:
# by the following command:
#
# pip-compile hail_search/requirements-test.in
# pip-compile requirements-test.in
#
aiohttp==3.9.2
# via pytest-aiohttp
Expand All @@ -12,6 +12,12 @@ async-timeout==4.0.2
# via aiohttp
attrs==23.1.0
# via aiohttp
cachetools==5.3.3
# via google-auth
certifi==2024.2.2
# via requests
charset-normalizer==3.3.2
# via requests
coverage==5.1
# via -r requirements-test.in
exceptiongroup==1.1.3
Expand All @@ -20,8 +26,31 @@ frozenlist==1.3.3
# via
# aiohttp
# aiosignal
google-api-core==2.17.1
# via
# google-cloud-core
# google-cloud-storage
google-auth==2.28.1
# via
# google-api-core
# google-cloud-core
# google-cloud-storage
google-cloud-core==2.4.1
# via google-cloud-storage
google-cloud-storage==2.14.0
# via -r requirements-test.in
google-crc32c==1.5.0
# via
# google-cloud-storage
# google-resumable-media
google-resumable-media==2.7.0
# via google-cloud-storage
googleapis-common-protos==1.62.0
# via google-api-core
idna==3.4
# via yarl
# via
# requests
# yarl
iniconfig==2.0.0
# via pytest
multidict==6.0.4
Expand All @@ -32,6 +61,16 @@ packaging==23.1
# via pytest
pluggy==1.2.0
# via pytest
protobuf==4.25.3
# via
# google-api-core
# googleapis-common-protos
pyasn1==0.5.1
# via
# pyasn1-modules
# rsa
pyasn1-modules==0.3.0
# via google-auth
pytest==7.4.0
# via
# pytest-aiohttp
Expand All @@ -40,7 +79,15 @@ pytest-aiohttp==1.0.4
# via -r requirements-test.in
pytest-asyncio==0.21.0
# via pytest-aiohttp
requests==2.31.0
# via
# google-api-core
# google-cloud-storage
rsa==4.9
# via google-auth
tomli==2.0.1
# via pytest
urllib3==2.2.1
# via requests
yarl==1.9.2
# via aiohttp
Loading