Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing dependencies and CMake flags #345

Merged

Conversation

erickisos
Copy link
Contributor

This is a follow up that should fix the macos issues reported here

@erickisos
Copy link
Contributor Author

Funny thing is that now it's failing on the MinGW jobs.

https://github.com/erickisos/calf/actions/runs/8011158865

@JohannesLorenz
Copy link
Collaborator

Thanks, this is really cool! I will look at it.

The MinGW jobs were never working, IIRC, so that is no problem.

src/CMakeLists.txt Outdated Show resolved Hide resolved
@JohannesLorenz
Copy link
Collaborator

Hi @erickisos . You rolled back, so I guess it did not work, and you want to submit the original solution using NOT APPLE?

@erickisos
Copy link
Contributor Author

Hey @JohannesLorenz, yes, I tried with your suggestion and it failed in the macos build, I'm not sure if there is other flag that can be used that it's supported by macos and other OS, I saw something about validating Linux instead, apparently is the only one that supports NODELETE.

@erickisos
Copy link
Contributor Author

erickisos commented Feb 25, 2024

Thanks for that change, neat

Copy link
Collaborator

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks again.

@JohannesLorenz JohannesLorenz merged commit 2eac8bc into calf-studio-gear:github-actions Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants