-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add missing dependencies and CMake flags #345
Fix: Add missing dependencies and CMake flags #345
Conversation
Funny thing is that now it's failing on the MinGW jobs. |
Thanks, this is really cool! I will look at it. The MinGW jobs were never working, IIRC, so that is no problem. |
Hi @erickisos . You rolled back, so I guess it did not work, and you want to submit the original solution using |
Hey @JohannesLorenz, yes, I tried with your suggestion and it failed in the macos build, I'm not sure if there is other flag that can be used that it's supported by macos and other OS, I saw something about validating Linux instead, apparently is the only one that supports NODELETE. |
CMake: Check for nodelete linker flag
Thanks for that change, neat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks again.
This is a follow up that should fix the macos issues reported here