Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if linker supports nodelete #46

Merged
merged 3 commits into from
May 14, 2024

Conversation

david0
Copy link
Contributor

@david0 david0 commented Dec 13, 2015

The Mac OS linker does not support -z,nodelete so I added an check for that and omitted this flag to make calf compile on OS X.

@david0 david0 force-pushed the test-nodelete branch 5 times, most recently from d2f1740 to fad27e4 Compare December 15, 2015 16:40
@IvanDSM
Copy link

IvanDSM commented Dec 30, 2016

@boomshop, has the functionality of this pull request been included in the master?

@boomshop
Copy link
Member

Not by now. I would like Krzysztof to review this request since he's responsible for make and autohell.

@JohannesLorenz
Copy link
Collaborator

@david0 Sorry for the slow reply. I was able to compile with MacOS now without this PR: https://github.com/calf-studio-gear/calf/actions/runs/6523823137 . Anyways, since you have a recent issue with this in david0/homebrew-audio#28, I guess it's best we just include your PR. I guess after 8 years, it should be stable enough? 😁

@JohannesLorenz JohannesLorenz added this to the 0.90.4 milestone Oct 21, 2023
@JohannesLorenz
Copy link
Collaborator

@david0 Friendly reminder that I would appreciate your input on this PR (see above post).

@david0
Copy link
Contributor Author

david0 commented Dec 19, 2023

@JohannesLorenz: Sorry for the delay, had to update my system to get XCode somewhat up to date 🙄

This PR is still valid, since nodelete is not supported by OS X. Most likely you compiled without GTK, since only for this case -Wl,nodelete is added.

@JohannesLorenz
Copy link
Collaborator

Hi @david0 . Your assumptions were correct. Now I added Gtk. However, even when I cherry-pick your commit onto my github-actions branch, I cannot compile: https://github.com/calf-studio-gear/calf/actions/runs/7515118130/job/20458734605 .

My github actions file does this:

      - name: Install dependencies
        run: brew install automake fluid-synth gtk+ cairo lv2
      - name: Check out
        uses: actions/checkout@v3
        with:
          fetch-depth: 0
      - name: Configure
        run: |
          mkdir build && cd build
          cmake .. -DCMAKE_INSTALL_PREFIX=../install
      - name: Build
        run: cmake --build build

Do you have any idea what I do wrong? How do you do it on your computer?

@JohannesLorenz
Copy link
Collaborator

@david0 Friendly reminder that I could need your help with compiling on macos-13 (please see above).

@JohannesLorenz
Copy link
Collaborator

Will merge, as this is indirectly confirmed in #345 .

Conflicts still need to be solved 😃

@JohannesLorenz
Copy link
Collaborator

JohannesLorenz commented May 13, 2024

PR for merge-conflicts-solving is up: david0#1

@JohannesLorenz JohannesLorenz merged commit a7e6cb4 into calf-studio-gear:master May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants