-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test if linker supports nodelete #46
Conversation
d2f1740
to
fad27e4
Compare
@boomshop, has the functionality of this pull request been included in the master? |
Not by now. I would like Krzysztof to review this request since he's responsible for make and autohell. |
@david0 Sorry for the slow reply. I was able to compile with MacOS now without this PR: https://github.com/calf-studio-gear/calf/actions/runs/6523823137 . Anyways, since you have a recent issue with this in david0/homebrew-audio#28, I guess it's best we just include your PR. I guess after 8 years, it should be stable enough? 😁 |
@david0 Friendly reminder that I would appreciate your input on this PR (see above post). |
@JohannesLorenz: Sorry for the delay, had to update my system to get XCode somewhat up to date 🙄 This PR is still valid, since nodelete is not supported by OS X. Most likely you compiled without GTK, since only for this case |
Hi @david0 . Your assumptions were correct. Now I added Gtk. However, even when I cherry-pick your commit onto my My github actions file does this:
Do you have any idea what I do wrong? How do you do it on your computer? |
@david0 Friendly reminder that I could need your help with compiling on macos-13 (please see above). |
Will merge, as this is indirectly confirmed in #345 . Conflicts still need to be solved 😃 |
PR for merge-conflicts-solving is up: david0#1 |
The Mac OS linker does not support
-z,nodelete
so I added an check for that and omitted this flag to make calf compile on OS X.