-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.6 feature merge #4271
1.6 feature merge #4271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpicks and questions around todos being ticketed.
I skipped review of the juliet crate as I have already done that on the feature branch and I assume it hasn't changed since then.
We do still need to decide if the crate gets its own repo or not. If not, then points made in the previous review which should be addressed include:
- decide the crate's name
- specify
edition = "2018"
(or upgrade all manifests in the repo) - add standard items to manifest's
[package]
section (especially thelicense
field) - update the README.md to include the standard blurb at the top and the license info
- add the crate to the casper-updater tool and
publish_to_crates_io.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review
There were some issue observed during manual run of the |
timeline on or before Monday 9th @SaiProServ |
bors try |
tryBuild succeeded: |
bors try |
tryMerge conflict. |
bors try |
tryBuild succeeded: |
Restore gossip peer selection
…equency Reduce warnings frequency
Overhaul networking metrics.
…etwork` pass again
Chainspec cost update
Will be reopened cleanly in a separate PR. |
This PR is a summary merge of every new feature and fix that has not made it to
dev
yet and is currently slated for a 1.6 release. Parts of the code have been reviewed already, but this does not apply to the entirety of the changes nor their combination.The PR contains multiple larger changesets:
juliet
crate and its integration into the node, forming the new base networking for the 1.6 release. There are some open TODOs, feel free to point them out, but follow-ups have been ticketed in most, if not all cases.While the review may seem a little daunting, if focusing on a single aspect at once (EE, juliet, integration of juliet and misc changes) should make it more manageable.
History is preserved, keeping some features that never made it to mainline, thus the high number of commits, along with numerous merge commits of
dev
back into the branch for compatibility.Closes #3941.