Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6 feature merge #4271

Closed
wants to merge 1,161 commits into from
Closed

1.6 feature merge #4271

wants to merge 1,161 commits into from

Conversation

marc-casperlabs
Copy link
Contributor

@marc-casperlabs marc-casperlabs commented Sep 5, 2023

This PR is a summary merge of every new feature and fix that has not made it to dev yet and is currently slated for a 1.6 release. Parts of the code have been reviewed already, but this does not apply to the entirety of the changes nor their combination.

The PR contains multiple larger changesets:

  • The juliet crate and its integration into the node, forming the new base networking for the 1.6 release. There are some open TODOs, feel free to point them out, but follow-ups have been ticketed in most, if not all cases.
  • EE changes:
    • Prunes withdraw keys post migration
    • Wasmi is updated to 0.13.2
    • Pruning is exposed as a new transform and could be found in the journal
    • Better error messages when trying to run Wasm with non-MVP opcodes
  • Smaller fixes, expanded test coverage (e.g. around metrics) and utility features and refactorings have been added.

While the review may seem a little daunting, if focusing on a single aspect at once (EE, juliet, integration of juliet and misc changes) should make it more manageable.

History is preserved, keeping some features that never made it to mainline, thus the high number of commits, along with numerous merge commits of dev back into the branch for compatibility.

Closes #3941.

Copy link
Contributor

@Fraser999 Fraser999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks and questions around todos being ticketed.

I skipped review of the juliet crate as I have already done that on the feature branch and I assume it hasn't changed since then.

We do still need to decide if the crate gets its own repo or not. If not, then points made in the previous review which should be addressed include:

  • decide the crate's name
  • specify edition = "2018" (or upgrade all manifests in the repo)
  • add standard items to manifest's [package] section (especially the license field)
  • update the README.md to include the standard blurb at the top and the license info
  • add the crate to the casper-updater tool and publish_to_crates_io.sh

Cargo.toml Outdated Show resolved Hide resolved
node/CHANGELOG.md Outdated Show resolved Hide resolved
node/Cargo.toml Show resolved Hide resolved
node/Cargo.toml Outdated Show resolved Hide resolved
node/src/components/network.rs Outdated Show resolved Hide resolved
node/src/components/network/connection_id.rs Outdated Show resolved Hide resolved
node/src/components/network/event.rs Outdated Show resolved Hide resolved
node/src/components/network/message.rs Outdated Show resolved Hide resolved
node/src/protocol.rs Outdated Show resolved Hide resolved
node/src/effect.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

juliet/src/varint.rs Outdated Show resolved Hide resolved
juliet/src/varint.rs Outdated Show resolved Hide resolved
juliet/src/header.rs Outdated Show resolved Hide resolved
@rafal-ch
Copy link
Contributor

There were some issue observed during manual run of the network_soundness.py (some or all nodes get stuck over time). It'll be good to resolve that before merging to dev in order not to break the nightly pipeline. Details have been discussed with @marc-casperlabs .

juliet/src/header.rs Outdated Show resolved Hide resolved
juliet/src/header.rs Outdated Show resolved Hide resolved
juliet/src/varint.rs Outdated Show resolved Hide resolved
@cspramit
Copy link
Contributor

cspramit commented Oct 2, 2023

timeline on or before Monday 9th @SaiProServ

@marc-casperlabs
Copy link
Contributor Author

bors try

casperlabs-bors-ng bot added a commit that referenced this pull request Oct 17, 2023
@casperlabs-bors-ng
Copy link
Contributor

try

Build succeeded:

@marc-casperlabs
Copy link
Contributor Author

bors try

Copy link
Contributor

try

Merge conflict.

@marc-casperlabs
Copy link
Contributor Author

bors try

casperlabs-bors-ng bot added a commit that referenced this pull request Nov 6, 2023
Copy link
Contributor

try

Build succeeded:

marc-casperlabs and others added 27 commits March 21, 2024 14:30
@marc-casperlabs
Copy link
Contributor Author

Will be reopened cleanly in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge feat-1.6 to dev
7 participants