chore(ci): Use dedicated action to install specified elvish version #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4452852
changed the title
epage
reviewed
Jan 7, 2025
Comment on lines
+95
to
98
| - uses: elves/setup-elvish@v1 | ||
| with: | ||
| elvish-version: 0.21.0 | ||
| - name: Install shells |
There was a problem hiding this comment.
A couple of concerns
- Dealing with the spread of versions of elvish that contributors will be using
- Updating elvish-version
(copied from #5869)
There was a problem hiding this comment.
The point of this change is that we could install the exact version we specify instead of depending on the system package manager (currently the version apt install on the CI is 0.17 which is very old).
The next question is which version we guarantee the compability?
There was a problem hiding this comment.
I don't have a good idea on what version should be our minimal (or even how to handle multiple incompatible versions). Leaving it to the distribution sets a low water mark that gets automatically updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.