Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use dedicated action to install specified elvish version #5870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(ci): Use dedicated action to install specified elvish version #5870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,12 @@ jobs:
with:
toolchain: stable
- uses: Swatinem/rust-cache@v2
- uses: elves/setup-elvish@v1
with:
elvish-version: 0.21.0
- name: Install shells
Comment on lines +95 to 98
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of concerns

  • Dealing with the spread of versions of elvish that contributors will be using
  • Updating elvish-version

(copied from #5869)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this change is that we could install the exact version we specify instead of depending on the system package manager (currently the version apt install on the CI is 0.17 which is very old).

The next question is which version we guarantee the compability?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a good idea on what version should be our minimal (or even how to handle multiple incompatible versions). Leaving it to the distribution sets a low water mark that gets automatically updated.

if: runner.os == 'Linux'
run: sudo apt-get install -y elvish fish zsh
run: sudo apt-get install -y fish zsh
- name: clap_complete
run: cargo test -p clap_complete -F unstable-dynamic -F unstable-shell-tests
shell-integration-nu:
Expand Down
10 changes: 5 additions & 5 deletions clap_complete/tests/testsuite/elvish.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,15 +184,15 @@ value value

let input = "exhaustive empty \t";
let expected = snapbox::str![[r#"
no candidates
error: no candidates
% exhaustive empty
"#]];
let actual = runtime.complete(input, &term).unwrap();
assert_data_eq!(actual, expected);

let input = "exhaustive --empty=\t";
let expected = snapbox::str![[r#"
no candidates
error: no candidates
% exhaustive --empty=
"#]];
let actual = runtime.complete(input, &term).unwrap();
Expand Down Expand Up @@ -324,8 +324,8 @@ fn complete_dynamic_empty_subcommand() {

let input = "exhaustive empty \t\t";
let expected = snapbox::str![[r#"
no candidates
no candidates
error: no candidates
error: no candidates
% exhaustive empty
"#]];
let actual = runtime.complete(input, &term).unwrap();
Expand All @@ -345,7 +345,7 @@ fn complete_dynamic_empty_option_value() {

let input = "exhaustive --empty=\t";
let expected = snapbox::str![[r#"
no candidates
error: no candidates
% exhaustive --empty=
"#]];
let actual = runtime.complete(input, &term).unwrap();
Expand Down
Loading