[notebook] fix notebook saving type

[sumtumn]

…ppet's type

What changes were proposed in this pull request?

• (Please fill in changes proposed in this fix)
  As described in Saved Notebooks no longer allow user to add snippets, also show Hive Editor history #3367 , I think it's wrong to save notebook type according the first snippet's type, because there are multi different types of snippets.

How was this patch tested?

• (Please explain how this patch was tested. Ex: unit tests, manual tests)
  manual tests

Please review Hue Contributing Guide before opening a pull request.

[bjornalm]

@sumtumn Thanks for the PR! We will review it shortly.

[amitsrivastava]

@sumtumn Can you please describe the issue in more detail? What value are you seeing without this fix vs what is expected. This helps in verifying the fix. Thanks.

Also, please shorten the title of you commit to avoid it getting cutoff.

[sumtumn]

@amitsrivastava
How to reproduce this:

1. Open notebook Editor
2. Add one or more snippet types (Hive, Scala, etc)
3. Save as Document
4. Open Document Browser
5. Load saved Notebook Document
6. The Notebook shows up, but does not allow the user to add more snippets to it or edit it outside of changing the existing queries.

Because the notebook type changed to be the first snippet's dialect while saveing notebook, e.g. the first snippet of the saved notebook was hive, then the saved notebook type was chaged to query-hive. This makes we can't add more snippets to the saved notebook. And it's also inappropriate because there are many different types of snippets in the same notebook, like hive, spark.

[bjornalm]

@amitsrivastava @Harshg999 @agl29 can we get som eyes on this PR?

[amitsrivastava]

LGTM

Thanks @sumtumn

[github-actions]

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

[bjornalm]

@Harshg999 Can you have a quick look and maybe we can merge this one?

[github-actions]

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

[risyomei]

I had the same issue on CDP 7.2.17's hue. resolved it with this PR.
@sumtumn Thanks man.