-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add in base patch changeset to get a version number live #36
build: Add in base patch changeset to get a version number live #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code review is regarding a version change on several packages in the repository. The change sees the versions of multiple packages being edited from 0.0.1 to 0.0.0. It is suspect because typically versions increase or advance, not decrease.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/bundler-plugin-core", | |||
"version": "0.0.1", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reversing the version number from 0.0.1 to 0.0.0 might not be a good idea as it is typically used to signify nonexistence of a version. Consider changing this to at least the initial base version 0.0.1 or higher as appropriate.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/rollup-plugin", | |||
"version": "0.0.1", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decreasing the version number could cause confusion or misinterpretation regarding the package's maturity or status. Keeping or increasing the version would be more aligned with common practices.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/vite-plugin", | |||
"version": "0.0.1", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the version to 0.0.0 may also cause compatibility issues with dependencies consuming this package expecting at least 0.0.1.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@codecov/webpack-plugin", | |||
"version": "0.0.1", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid setting the version to 0.0.0. Instead, if this represents a pre-release version, consider a versioning scheme like 0.0.1-alpha.1 or similar.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Description
It seems like we need a base changeset present for the pre-release stuff to work properly.