Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add in base patch changeset to get a version number live #36

Conversation

nicholas-codecov
Copy link
Collaborator

Description

It seems like we need a base changeset present for the pre-release stuff to work properly.

Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code review is regarding a version change on several packages in the repository. The change sees the versions of multiple packages being edited from 0.0.1 to 0.0.0. It is suspect because typically versions increase or advance, not decrease.

@@ -1,6 +1,6 @@
{
"name": "@codecov/bundler-plugin-core",
"version": "0.0.1",
"version": "0.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reversing the version number from 0.0.1 to 0.0.0 might not be a good idea as it is typically used to signify nonexistence of a version. Consider changing this to at least the initial base version 0.0.1 or higher as appropriate.

@@ -1,6 +1,6 @@
{
"name": "@codecov/rollup-plugin",
"version": "0.0.1",
"version": "0.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decreasing the version number could cause confusion or misinterpretation regarding the package's maturity or status. Keeping or increasing the version would be more aligned with common practices.

@@ -1,6 +1,6 @@
{
"name": "@codecov/vite-plugin",
"version": "0.0.1",
"version": "0.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the version to 0.0.0 may also cause compatibility issues with dependencies consuming this package expecting at least 0.0.1.

@@ -1,6 +1,6 @@
{
"name": "@codecov/webpack-plugin",
"version": "0.0.1",
"version": "0.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid setting the version to 0.0.0. Instead, if this represents a pre-release version, consider a versioning scheme like 0.0.1-alpha.1 or similar.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b9d8e8) 83.52% compared to head (ac20484) 83.52%.

Additional details and impacted files
Components Coverage Δ
Plugin core 96.33% <ø> (ø)
Rollup plugin 7.35% <ø> (ø)
Vite plugin 7.35% <ø> (ø)
Webpack plugin 33.33% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholas-codecov nicholas-codecov merged commit 36ed299 into main Dec 21, 2023
13 checks passed
@nicholas-codecov nicholas-codecov deleted the bump-versions-down-as-i-guess-we-need-a-min-changeset-version branch December 21, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants