Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add in base patch changeset to get a version number live #36

Merged
merged 2 commits into from
Dec 21, 2023
Merged

build: Add in base patch changeset to get a version number live #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49b093f
swap version numbers to zero
nicholas-codecov Dec 21, 2023
ac20484
add in base changeset file
nicholas-codecov Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/poor-cows-kneel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@codecov/bundler-plugin-core": patch
"@codecov/webpack-plugin": patch
"@codecov/rollup-plugin": patch
"@codecov/vite-plugin": patch
---

Alpha release of Codecov bundler plugins
2 changes: 1 addition & 1 deletion packages/bundler-plugin-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codecov/bundler-plugin-core",
"version": "0.0.1",
"version": "0.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reversing the version number from 0.0.1 to 0.0.0 might not be a good idea as it is typically used to signify nonexistence of a version. Consider changing this to at least the initial base version 0.0.1 or higher as appropriate.

"description": "Official Codecov Bundler Plugin Core",
"author": "Codecov",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/rollup-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codecov/rollup-plugin",
"version": "0.0.1",
"version": "0.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decreasing the version number could cause confusion or misinterpretation regarding the package's maturity or status. Keeping or increasing the version would be more aligned with common practices.

"description": "Official Codecov Rollup plugin",
"author": "Codecov",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codecov/vite-plugin",
"version": "0.0.1",
"version": "0.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the version to 0.0.0 may also cause compatibility issues with dependencies consuming this package expecting at least 0.0.1.

"description": "Official Codecov Vite plugin",
"author": "Codecov",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion packages/webpack-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@codecov/webpack-plugin",
"version": "0.0.1",
"version": "0.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid setting the version to 0.0.0. Instead, if this represents a pre-release version, consider a versioning scheme like 0.0.1-alpha.1 or similar.

"description": "Official Codecov Webpack plugin",
"author": "Codecov",
"license": "MIT",
Expand Down