cache ToolchainCluster CR only in the given namespace #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
rajivnathan
approved these changes
Aug 1, 2024
alexeykazakov
requested changes
Aug 1, 2024
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
alexeykazakov
approved these changes
Aug 2, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexeykazakov, fbm3307, rajivnathan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
=======================================
Coverage 85.06% 85.06%
=======================================
Files 55 55
Lines 5034 5034
=======================================
Hits 4282 4282
Misses 581 581
Partials 171 171 |
|
It looks like that there is no change in this PR anymore as the toolchain-common dependency was updated via another PR that is already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to codeready-toolchain/toolchain-common#419
This is just a dependency check