Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache ToolchainCluster CR only in the given namespace #419

Merged
merged 1 commit into from
Jul 26, 2024
Merged

cache ToolchainCluster CR only in the given namespace #419

merged 1 commit into from
Jul 26, 2024

Conversation

MatousJobanek
Copy link
Contributor

@MatousJobanek MatousJobanek commented Jul 26, 2024 •
edited by fbm3307
Loading

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.52%. Comparing base (2f6e6a3) to head (474ff3c).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   78.47%   78.52%   +0.04%     
==========================================
  Files          48       49       +1     
  Lines        2012     2021       +9     
==========================================
+ Hits         1579     1587       +8     
- Misses        375      376       +1     
  Partials       58       58
Files Coverage Δ
...llers/toolchainclustercache/namespace_predicate.go 100.00% <100.00%> (ø)
...nclustercache/toolchaincluster_cache_controller.go 43.47% <0.00%> (-1.98%) ⬇️

This was referenced Jul 26, 2024
Closed
Closed
rajivnathan
rajivnathan approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this so quickly! 🚀

@rajivnathan rajivnathan merged commit 74c7003 into codeready-toolchain:master Jul 26, 2024
8 checks passed
alexeykazakov
alexeykazakov reviewed Jul 26, 2024
View reviewed changes
controllers/toolchainclustercache/namespace_predicate.go
"sigs.k8s.io/controller-runtime/pkg/event"
)

// CreateAndUpdateOnlyPredicate will filter out all events out of the provided namespace
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

// namespacePredicate will filter out all events out of the provided namespace

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykazakov alexeykazakov alexeykazakov left review comments

@rajivnathan rajivnathan rajivnathan approved these changes

@mfrancisc mfrancisc mfrancisc approved these changes

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@sbryzak sbryzak Awaiting requested review from sbryzak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatousJobanek @alexeykazakov @mfrancisc @rajivnathan