feat: Support waiting for faucet transactions #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the faucet transaction payload to reflect what our API now returns.
alex-stone
force-pushed
the
stone/async-faucet-tx
branch
from
a0707f5 to
0c44549
Compare
alex-stone
force-pushed
the
stone/async-faucet-tx
branch
from
0c44549 to
686b790
Compare
cdp/faucet_transaction.py
Outdated
| """Get the faucet transaction status. | ||
|
|
||
| Returns: | ||
| str: The facuet transaction status. |
There was a problem hiding this comment.
Suggested change
| str: The facuet transaction status. | |
| str: The faucet transaction status. |
cdp/transaction.py
Outdated
| @@ -104,6 +104,11 @@ def transaction_hash(self) -> str: | |||
| """Get the transaction hash.""" | |||
| return self._model.transaction_hash | |||
|
|
|||
| @property | |||
| def network_id(self) -> str: | |||
| """Get the Network ID of the Transfer.""" | |||
There was a problem hiding this comment.
Suggested change
| """Get the Network ID of the Transfer.""" | |
| """Get the Network ID of the Transaction.""" |
John-peterson-coinbase
approved these changes
Oct 30, 2024
Merged
alex-stone
added a commit
that referenced
this pull request
Oct 31, 2024
* feat: Support waiting for faucet transactions (#38) * chore: Bump OpenAPI client * chore: Add network_id to Transaction resource * chore: Update faucet transaction payload This updates the faucet transaction payload to reflect what our API now returns. * feat: Support fetching faucet transaction status * chore: Add status and network to faucet transaction string * chore: Fix typos * chore: Prepare v0.10.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This adds support for waiting for faucet transactions on the SDK side instead of on the server-side.
This pattern mirrors the
waitparadigm for other inherently async processes (e.g. transfers, contract invocations, traces, etc...), and also extends to more networks where block time may or may not be slower.Qualified Impact