ConfigHandler: make updateIdeSettings work (better)

[owtaylor]

Description

ConfigHandler.updateIdeSettings() was largely ineffective because the ideSettingsPromise was stored in the ProfileLoader object, so updating to a new ideSettingsPromise resulted in the config being reloaded with the old settings. Fix this by passing the ideSettingsPromise as a parameter to IProfileLoader.doLoadConfig().

I came up with this while working on a larger change (for automatic model selection), so I don't have a great example of when this would matter, but it does seem like this would affect the use of ideSettings.userToken in core/llm/llms/index.ts -

  if (desc.provider === "continue-proxy") {
    options.apiKey = ideSettings.userToken;
    if (ideSettings.remoteConfigServerUrl) {
      options.apiBase = new URL(
        "/proxy/v1",
        ideSettings.remoteConfigServerUrl,
      ).toString();
    }
  }

This patch does not fix the case where changing the settings affects what profiles (changes to ideSettings.remoteConfigServerUrl)

Checklist

• The relevant docs, if any, have been updated or created
• The relevant tests, if any, have been updated or created

[netlify]

✅ Deploy Preview for continuedev ready!

Name	Link
🔨 Latest commit	6636386
🔍 Latest deploy log	https://app.netlify.com/sites/continuedev/deploys/677c2a105db8080008b5d256
😎 Deploy Preview	https://deploy-preview-3456--continuedev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[owtaylor]

Rebased to fix conflicts

[sestinj]

@owtaylor I appreciate this fix! I agree that it cleans things up, and so it's kind of awkward to say this (especially 3 weeks after your PR was opened), but given that we're going to be removing the need for these remoteConfigServer features, I'm going to close this in favor of the larger change we'll make soon. Before then it feels wise to avoid any kind of shake up in such a core part of the codebase. Again, thank you for taking the time to look into this!

[owtaylor]

@owtaylor I appreciate this fix! I agree that it cleans things up, and so it's kind of awkward to say this (especially 3 weeks after your PR was opened), but given that we're going to be removing the need for these remoteConfigServer features, I'm going to close this in favor of the larger change we'll make soon. Before then it feels wise to avoid any kind of shake up in such a core part of the codebase. Again, thank you for taking the time to look into this!

I've certainly been there as a maintainer with a contributed patch a lot of times! Thanks for letting me know the situation.