refactor: use runtime env in ibc 08-wasm client module #7836
+37
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces: #7766
This PR is work-in-progress and should not be merged until completed.
The usage of sdk.Context should try to be removed completely.
The 08-wasm module is still relying on sdk.Context in the keeper for gas consumption.
This can be refactored out and replaced by k.GasService.
The usage of the legacy baseapp GRPCQueryRouter for the 08-wasm Querier should also try to be replaced by adding the new query router to the runtime environment using runtime.EnvWithQueryRouterService(app.GRPCQueryRouter()).
Main tasks left to complete:
ref: Migrate to cosmos-sdk
appmodule.Environment
in ibc #7712Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.