Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Suppress equal fold diff for DLT pipeline resource #4196

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

shreyas-goenka
Copy link
Contributor

Changes

Fixes databricks/cli#1763. During creation the catalog name for a DLT pipeline is normalized to small case causing a persistent drift.

Tests

Manually with the following configuration:

resource "databricks_pipeline" "this" {
  name = "testing caps"
  catalog = "MaiN"
  library {
    notebook {
      path = "/a/b/c"
    }
  }
}

Before:
There'd be a persistent drift where terraform would try to convert "MaiN" -> "main"

After:
No diff detected.

@shreyas-goenka shreyas-goenka requested review from a team as code owners November 6, 2024 09:23
@shreyas-goenka shreyas-goenka requested review from tanmay-db and removed request for a team November 6, 2024 09:23
@shreyas-goenka shreyas-goenka changed the title Suppress equal fold diff for DLT pipeline resource [Fix] Suppress equal fold diff for DLT pipeline resource Nov 6, 2024
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but let check for the schema field as well

pipelines/resource_pipeline.go Show resolved Hide resolved
Copy link

github-actions bot commented Nov 6, 2024

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4196
  • Commit SHA: bdb988cbea7714afe819f8021a46b9a13b4f5190

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11702135145

@shreyas-goenka shreyas-goenka added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 5058e50 Nov 6, 2024
12 checks passed
@shreyas-goenka shreyas-goenka deleted the suppress-dlt-catalog branch November 6, 2024 13:03
tanmay-db added a commit that referenced this pull request Nov 8, 2024
### Bug Fixes

 * Always fill `cluster_name` in `databricks_cluster` data source ([#4197](#4197)).
 * Suppress equal fold diff for DLT pipeline resource ([#4196](#4196)).
 * Upload content `databricks_workspace_file` using raw format ([#4200](#4200)).

### Internal Changes

 * Update to latest OpenAPI spec and bump Go SDK ([#4199](#4199)).

### Dependency Updates

 * Bump github.com/golang-jwt/jwt/v4 from 4.5.0 to 4.5.1 ([#4191](#4191)).
tanmay-db added a commit that referenced this pull request Nov 8, 2024
### Bug Fixes

* Always fill `cluster_name` in `databricks_cluster` data source
([#4197](#4197)).
* Suppress equal fold diff for DLT pipeline resource
([#4196](#4196)).
* Upload content `databricks_workspace_file` using raw format
([#4200](#4200)).


### Internal Changes

* Update to latest OpenAPI spec and bump Go SDK
([#4199](#4199)).


### Dependency Updates

* Bump github.com/golang-jwt/jwt/v4 from 4.5.0 to 4.5.1
([#4191](#4191)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a warning when UC resource references or names contains capital letters
3 participants