Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Suppress equal fold diff for DLT pipeline resource #4196

Merged
merged 2 commits into from
Nov 6, 2024
Merged

[Fix] Suppress equal fold diff for DLT pipeline resource #4196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f8591
Suppress equal fold diff for DLT pipeline resource
shreyas-goenka Nov 6, 2024
bdb988c
update comment
shreyas-goenka Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pipelines/resource_pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,11 @@ func (Pipeline) CustomizeSchema(s *common.CustomizableSchema) *common.Customizab
s.SchemaPath("edition").SetCustomSuppressDiff(common.EqualFoldDiffSuppress)
s.SchemaPath("storage").SetCustomSuppressDiff(suppressStorageDiff)

// As of 6th Nov 2024, the DLT API only normalizes the catalog name when creating
// a pipeline. So we only ignore the equal fold diff for the catalog name and not other
// UC resources like target, schema or ingestion_definition.connection_name.
s.SchemaPath("catalog").SetCustomSuppressDiff(common.EqualFoldDiffSuppress)
shreyas-goenka marked this conversation as resolved.
Show resolved Hide resolved

// Deprecated fields
s.SchemaPath("cluster", "init_scripts", "dbfs").SetDeprecated(clusters.DbfsDeprecationWarning)
s.SchemaPath("library", "whl").SetDeprecated("The 'whl' field is deprecated")
Expand Down
Loading