Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Poetry 1.8.5 for Python 3.8 #11231

Closed
wants to merge 3 commits into from

Conversation

edgarrmondragon
Copy link

@edgarrmondragon edgarrmondragon commented Jan 5, 2025

What are you trying to accomplish?

Poetry 2.0 dropped support for Python 3.8, so this ensures a version Poetry can be installed until support for Python 3.8 is dropped.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up.

However, given that 3.8 was EOL'd in October, and we've already started marking it as deprecated (#11166) we may be able to bypass this completely and simply drop 3.8 within the next few weeks:

@amazimbe is working on that and can speak to the timeline more.

@@ -6,7 +6,8 @@ hashin==1.0.2; python_version < '3.9'
hashin==1.0.3; python_version >= '3.9'
pipenv==2024.0.2
plette==2.1.0
poetry==1.8.5
poetry==1.8.5; python_version < "3.9"
poetry==2.0.0; python_version >= "3.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively bumps to Poetry 2.0.0... that's a much bigger change than just pinning poetry 1.8.5

I would not be surprised if this part of this change introduces a bunch of breakage that needs fixing...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @jeffwidman! I wasn't aware the 3.8 deprecation was so close to being dropped. I agree that there will be breaking changes when bumping to Poetry 2.0, but I unfortunately can't work on fixing those at the moment.

@edgarrmondragon edgarrmondragon deleted the poetry2 branch January 7, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants