Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Poetry 1.8.5 for Python 3.8 #11231

Closed
wants to merge 3 commits into from
Closed

Use Poetry 1.8.5 for Python 3.8 #11231

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6829c80
Use Poetry 1.8.5 for Python 3.8
edgarrmondragon Jan 5, 2025
7f0fbec
Merge branch 'main' into poetry2
edgarrmondragon Jan 6, 2025
9354c90
Do not pin poetry==2.0.0 yet
edgarrmondragon Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/helpers/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ hashin==1.0.2; python_version < '3.9'
hashin==1.0.3; python_version >= '3.9'
pipenv==2024.0.2
plette==2.1.0
poetry==1.8.5
poetry==1.8.5; python_version < "3.9"
poetry==2.0.0; python_version >= "3.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively bumps to Poetry 2.0.0... that's a much bigger change than just pinning poetry 1.8.5

I would not be surprised if this part of this change introduces a bunch of breakage that needs fixing...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @jeffwidman! I wasn't aware the 3.8 deprecation was so close to being dropped. I agree that there will be breaking changes when bumping to Poetry 2.0, but I unfortunately can't work on fixing those at the moment.

# TODO: Replace 3p package `toml` with 3.11's new stdlib `tomllib` once we drop support for Python 3.10.
toml==0.10.2

Expand Down
Loading