Andri/last used #2683
Merged
Andri/last used #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formatted in devices list if available
lmuntaner
approved these changes
Nov 1, 2024
| @@ -129,7 +129,7 @@ export const authenticatorItem = ({ | |||
| let lastUsageTimeStamp: Date | undefined; | |||
| let lastUsageFormattedString: string | undefined; | |||
|
|
|||
| if (last_usage.length > 0 && typeof last_usage[0] === "bigint") { | |||
| if (last_usage?.length > 0 && typeof last_usage[0] === "bigint") { | |||
There was a problem hiding this comment.
If the value is optional, shouldn't you have kept a test that asserts its optionality?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add well-formatted and tested last usage date for each authentication device. This was already PR-ed, this new commit is a fix for the showcase screenshots. last_used is undefined on page load, so it doesn't yet have a length, so querying its length throws an error which broke the showcase. Fixed it by using optional chaining in the if clause in question.
🟡 Some screens were changed