Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andri/last used #2683

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Andri/last used #2683

Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6b369c5
start replacing DeviceData with DeviceWithUsage
LXIF Oct 31, 2024
73dc3c8
finish replacing DeviceData with DeviceWithUsage, display last_usage …
LXIF Oct 31, 2024
9f41701
remove unnecessary console log
LXIF Oct 31, 2024
ccdfc22
BigInt in types -> bigint
LXIF Oct 31, 2024
37f1faf
adjust formatting
LXIF Oct 31, 2024
31d8d5c
rearrange and use relative time format
LXIF Nov 1, 2024
d5651d7
format
LXIF Nov 1, 2024
699fe8b
Merge branch 'main' into andri/last_used
LXIF Nov 1, 2024
773dffb
create time format helper utility and tests
LXIF Nov 1, 2024
eae18cd
format
LXIF Nov 1, 2024
9a5c60a
fix showcase
LXIF Nov 1, 2024
3d81bd9
Merge branch 'main' into andri/last_used
LXIF Nov 1, 2024
bfed34b
add mock data for showcase
LXIF Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/frontend/src/flows/manage/authenticatorsSection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export const authenticatorItem = ({
let lastUsageTimeStamp: Date | undefined;
let lastUsageFormattedString: string | undefined;

if (last_usage.length > 0 && typeof last_usage[0] === "bigint") {
if (last_usage?.length > 0 && typeof last_usage[0] === "bigint") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the value is optional, shouldn't you have kept a test that asserts its optionality?

lastUsageTimeStamp = new Date(Number(last_usage[0] / BigInt(1000000)));
}

Expand Down