-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent orphaned contact cards #3282
Conversation
@charludo |
4967b5c
to
b2e6bb2
Compare
done |
b2e6bb2
to
78a40b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, the protection functions as expected 😸
I have some suggestion for improvement:
- Can we probably add to the tests such cases that archiving/deleting is prevented due to referring contents?
- It's even more cool if error messages are bundled that appear when contacts cannt be bulk archived/deleted, like the corresponding success messages?
- Deactivating the buttons if the contact is protected: you can open an issue for this if you think better to separate.
78a40b8
to
a295ac3
Compare
Absolutely!
Done!
Done! |
d36db85
to
16e1cb1
Compare
16e1cb1
to
638674c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
This looks really good 🚀
DRAFT until #3169 is mergedShort description
Prevent the deletion of contacts as long as pages/pois/events still referr to it. Note that no list of objects referring to the contact in question is shown in the error message, since we show that list in the contact details anyways.
Proposed changes
Side effects
Resolved issues
Fixes: #3260
Pull Request Review Guidelines