DEV: Remove use of --squash flag and switch to buildx
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
commented
Oct 13, 2023
image/auto_build.rb
Outdated
| raise "Error building the image for #{image[:name]}: #{lines[-1]}" if lines[-1] =~ /successfully built/ | ||
| lines = | ||
| run( | ||
| "cd #{image[:name]} && docker buildx build . --no-cache --tag #{image[:tag]} #{image[:extra_args] ? image[:extra_args] : ""}", |
There was a problem hiding this comment.
Actual change is here. The rest of the changes in this file is just linting due to syntax_tree.
tgxworld
commented
Oct 13, 2023
Comment on lines
+12
to
+16
| base_slim_arm64: { | ||
| name: "base", | ||
| tag: "discourse/base:build_slim_arm64", | ||
| extra_args: "-f slim.Dockerfile --platform linux/arm64", | ||
| }, |
There was a problem hiding this comment.
New image added here.
|
@davidtaylorhq @xfalcox Can I trouble you guys for a review here? Thank you! 🙇 |
davidtaylorhq
approved these changes
Oct 13, 2023
|
I think we could also remove: discourse_docker/.github/workflows/build.yml Lines 21 to 25 in 246f03b |
tgxworld
force-pushed
the
remove_use_of_docker_squash
branch
from
5d0766f to
7d60658
Compare
Why this change? In CI, we are seeing the following warning message: ``` WARNING: experimental flag squash is removed with BuildKit. You should squash inside build using a multi-stage Dockerfile for efficiency. ``` Basically, the `--squash` flag has not been working for quite some time and is redundant. What does this change do? * This change removes the use of the `--squash` flag. * This change uses the `buildx` tool in `auto_build.rb` as we prepare to build images for multiple platforms.
tgxworld
force-pushed
the
remove_use_of_docker_squash
branch
from
7d60658 to
9a6ec1b
Compare
|
Thank you for reviewing @davidtaylorhq 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
In CI, we are seeing the following warning message:
Basically, the
--squashflag has not been working for quite some time and is redundant.What does this change do?
This change removes the use of the
--squashflag.This change uses the
buildxtool inauto_build.rbas we prepare to build images for multiple platforms.