Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Remove use of --squash flag and switch to buildx #743

Merged
merged 1 commit into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ jobs:
runs-on: ubuntu-20.04${{ ((github.event_name != 'schedule') && '-8core') || '' }}
timeout-minutes: 90
steps:
- name: enable experimental docker features
run: |
sudo bash -c 'echo "{ \"cgroup-parent\": \"/actions_job\",\"experimental\":true}" > /etc/docker/daemon.json'
sudo service docker restart
docker version -f '{{.Server.Experimental}}'
- uses: actions/checkout@v3
with:
fetch-depth: 1
Expand Down Expand Up @@ -142,14 +137,9 @@ jobs:
id: buildx
uses: docker/setup-buildx-action@v2
- name: build slim image
working-directory: image/base
run: |
docker buildx build . --load \
-f slim.Dockerfile \
--platform linux/arm64 \
--tag discourse/base:aarch64-slim
docker tag discourse/base:aarch64-slim localhost:5000/discourse/base:aarch64-slim
docker push localhost:5000/discourse/base:aarch64-slim
cd image && ruby auto_build.rb base_slim_arm64
docker tag discourse/base:aarch64-slim localhost:5000/discourse/base:build_slim_arm64
- name: tag slim image as release
working-directory: image/base
run: |
Expand Down
44 changes: 35 additions & 9 deletions image/auto_build.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,32 @@
# simple build file to be used locally by Sam
#
require 'pty'
require 'optparse'
require "pty"
require "optparse"

images = {
base_slim: { name: 'base', tag: "discourse/base:build_slim", squash: true, extra_args: '-f slim.Dockerfile' },
base: { name: 'base', tag: "discourse/base:build", extra_args: '-f release.Dockerfile' },
discourse_test_build: { name: 'discourse_test', tag: "discourse/discourse_test:build", squash: false},
discourse_dev: { name: 'discourse_dev', tag: "discourse/discourse_dev:build", squash: false },
base_slim: {
name: "base",
tag: "discourse/base:build_slim",
extra_args: "-f slim.Dockerfile",
},
base_slim_arm64: {
name: "base",
tag: "discourse/base:build_slim_arm64",
extra_args: "-f slim.Dockerfile --platform linux/arm64",
},
Comment on lines +12 to +16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New image added here.

base: {
name: "base",
tag: "discourse/base:build",
extra_args: "-f release.Dockerfile",
},
discourse_test_build: {
name: "discourse_test",
tag: "discourse/discourse_test:build",
},
discourse_dev: {
name: "discourse_dev",
tag: "discourse/discourse_dev:build",
},
}

def run(command)
Expand All @@ -30,12 +49,19 @@ def run(command)
end

def build(image)
lines = run("cd #{image[:name]} && docker build . --no-cache --tag #{image[:tag]} #{image[:squash] ? '--squash' : ''} #{image[:extra_args] ? image[:extra_args] : ''}")
raise "Error building the image for #{image[:name]}: #{lines[-1]}" if lines[-1] =~ /successfully built/
lines =
run(
"cd #{image[:name]} && docker buildx build . --load --no-cache --tag #{image[:tag]} #{image[:extra_args] ? image[:extra_args] : ""}",
)
if lines[-1] =~ /successfully built/
raise "Error building the image for #{image[:name]}: #{lines[-1]}"
end
end

def dev_deps()
run("sed -e 's/\(db_name: discourse\)/\1_development/' ../templates/postgres.template.yml > discourse_dev/postgres.template.yml")
run(
"sed -e 's/\(db_name: discourse\)/\1_development/' ../templates/postgres.template.yml > discourse_dev/postgres.template.yml",
)
run("cp ../templates/redis.template.yml discourse_dev/redis.template.yml")
end

Expand Down