Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port over adapters #73

Merged
merged 32 commits into from
Nov 8, 2024
Merged

Port over adapters #73

merged 32 commits into from
Nov 8, 2024

Conversation

dlrice
Copy link
Contributor

@dlrice dlrice commented Nov 6, 2024 •
edited
Loading

Note

jest-haste-map: duplicate manual mock found: uniprotkb-entry-data
  The following files share their name; please delete one of them:
    * <rootDir>/dist/es/adapters/__mocks__/uniprotkb-entry-data.js
    * <rootDir>/dist/es/adapters/__tests__/__mocks__/uniprotkb-entry-data.js

but I couldn't figure out how to remove them. Leaving for now as they don't impact anything. Suggestions welcome.

Description of changes

  • Moved adapters into own directory
  • Move tooltips into own directory
  • Standardize all files to be kebab-case
  • Use more types from nightingale
  • Remove unused code
  • Use lit to register web components
  • Update exports to remove unused and add tooltips

Testing/Styleguide

  • Tests pass
  • Linters pass

dlrice added 25 commits November 5, 2024 10:56
@dlrice
Initial move of adapters.
f36608e
@dlrice
Slight restructure.
a3338aa
@dlrice
More restructuring.
274bfbe
@dlrice
Move lots of things around.
d5a25fa
@dlrice
Drop protvista-X and transormDataX prefixes; move types around.
54990f2
@dlrice
Update .gitignore for yalc.
0e4b23b
@dlrice
Remove packages.
3a60d29
@dlrice
Remove types already in nightingale.
a998a47
@dlrice
Fix proteomics-ptm-adapter import.
d3f50e0
@dlrice
Fix type imports for variants.
2ef7898
@dlrice
Type fixes.
e26c053
@dlrice
Update test.
7740f0c
@dlrice
Move tests around and save as ts.
8b39038
@dlrice
Fix filter-config types.
5aebdde
@dlrice
Update snapshot.
cc9d03b
@dlrice
Remove unused code.
51d651a
@dlrice
Remove yalc references.
4985ca7
@dlrice
Export tooltips from index.
36ae063
@dlrice
Tweak index.html title, remove unused d3 v4 load.
a8ebd5b
@dlrice
Have lit register the web components.
cda1741
@dlrice
Remove gitHead from package.json.
ae9253e
@dlrice
Still need loadComponent though for the individual tracks.
0081a39
@dlrice
Tidy up debugging statements.
2ddcf7b
@dlrice
Remove unused types and move a few others around.
11a0992
@dlrice
Remove link-all and add-all package.json scripts as only yalc is used.
a124e7e
Swaathik
Swaathik requested changes Nov 7, 2024
View reviewed changes
package.json Outdated
@@ -36,26 +34,24 @@
"@nightingale-elements/nightingale-structure": "5.2.0",
"@nightingale-elements/nightingale-track": "5.2.0",
"@nightingale-elements/nightingale-variation": "5.2.0",
"color-hash": "^2.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just using the fixed version like the rest of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned all dep versions but not devDeps as I encountered webpack issues so left as is there.

src/protvista-uniprot.ts Outdated

import ProtvistaUniprotStructure from './protvista-uniprot-structure';

import { load } from 'data-loader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data-loader from the old version is used only in two places. we can replace it with fetch()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

src/protvista-uniprot.ts Outdated
@@ -124,7 +101,7 @@ type ProtvistaCategory = {
'color-range'?: string;
};

export type DownloadConfig = {
type DownloadConfig = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have download in protvista-uniprot anymore. we can delete it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@dlrice dlrice merged commit 2057f53 into master Nov 8, 2024
@dlrice dlrice deleted the port-over-adapters branch November 12, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swaathik Swaathik Swaathik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlrice @Swaathik